Skip to content

Commit 93194e1

Browse files
authored
fix: requests headers none argument fix (open-telemetry#708)
1 parent 1041e11 commit 93194e1

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

ext/opentelemetry-ext-requests/src/opentelemetry/ext/requests/__init__.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,9 @@ def instrumented_request(self, method, url, *args, **kwargs):
9696
span.set_attribute("http.method", method.upper())
9797
span.set_attribute("http.url", url)
9898

99-
headers = kwargs.setdefault("headers", {})
99+
headers = kwargs.get("headers", {}) or {}
100100
propagators.inject(type(headers).__setitem__, headers)
101+
kwargs["headers"] = headers
101102

102103
try:
103104
result = wrapped(

ext/opentelemetry-ext-requests/tests/test_requests_integration.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,10 @@ def test_custom_tracer_provider(self):
228228

229229
self.assertIs(span.resource, resource)
230230

231+
def test_if_headers_equals_none(self):
232+
result = requests.get(self.URL, headers=None)
233+
self.assertEqual(result.text, "Hello!")
234+
231235
@mock.patch("requests.Session.send", side_effect=requests.RequestException)
232236
def test_requests_exception_without_response(self, *_, **__):
233237

0 commit comments

Comments
 (0)