fix conditional swap order (#1639)

* add timeout to jobs

* feat: Add support for Binance USDS-M Futures conditional/algo orders

This update adds support for Binance's new algo order endpoints for conditional orders, which will be mandatory after 2025-12-09 for order types: STOP, STOP_MARKET, TAKE_PROFIT, TAKE_PROFIT_MARKET, and TRAILING_STOP_MARKET.

Changes:
- Added new order status enums: ACCEPTED, TRIGGERING, TRIGGERED, FINISHED
- Added new dedicated algo order methods:
  * futures_create_algo_order() / async
  * futures_get_algo_order() / async
  * futures_get_all_algo_orders() / async
  * futures_get_open_algo_orders() / async
  * futures_cancel_algo_order() / async
  * futures_cancel_all_algo_open_orders() / async
- Updated existing futures order methods to auto-detect and route conditional orders:
  * futures_create_order() now automatically routes conditional order types to algo endpoint
  * futures_get_order() supports 'conditional' parameter and algoId/clientAlgoId
  * futures_get_all_orders() supports 'conditional' parameter
  * futures_get_open_orders() supports 'conditional' parameter
  * futures_cancel_order() supports 'conditional' parameter and algoId/clientAlgoId
  * futures_cancel_all_open_orders() supports 'conditional' parameter
- Applied same changes to both sync (client.py) and async (async_client.py) clients

References:
- https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api/New-Algo-Order
- https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api/Cancel-Algo-Order
- https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api/Query-Algo-Order

* test: Add comprehensive tests for algo/conditional orders

Added tests for both sync and async clients covering:
- Creating algo orders via dedicated method
- Auto-routing conditional orders in futures_create_order
- Getting specific algo orders
- Getting all algo orders history
- Getting open algo orders
- Canceling algo orders
- Canceling all algo open orders
- Using conditional parameter with existing methods

Tests validate both the new dedicated algo order methods and the
backward-compatible conditional parameter on existing methods.

* fix: Use lowercase 'triggerprice' parameter for algo orders

The Binance API expects the trigger price parameter to be lowercase
'triggerprice' not camelCase 'triggerPrice'. Updated both client
implementations and tests to use the correct parameter name.

Changes:
- Updated futures_create_order to convert triggerPrice -> triggerprice
- Added handling for both camelCase and lowercase input
- Updated all tests to use lowercase 'triggerprice' parameter
- Fixes APIError: Mandatory parameter 'triggerprice' was not sent

This ensures compatibility with Binance's algo order endpoints which
expect lowercase parameter names for trigger prices.

* fix: Revert to camelCase 'triggerPrice' per official API docs

After reviewing the official Binance API documentation at:
https://developers.binance.com/docs/derivatives/usds-margined-futures/trade/rest-api/New-Algo-Order

The parameter is clearly documented as 'triggerPrice' (camelCase), not 'triggerprice' (lowercase).

Example from API docs:
- Parameter: triggerPrice (DECIMAL, NO)
- Response field: "triggerPrice": "750.000"

Changes:
- Reverted futures_create_order to use triggerPrice (camelCase)
- Updated tests to use triggerPrice (camelCase)
- Removed incorrect lowercase conversion

The API error message may display parameter names in lowercase, but the
actual parameter expected by the API is camelCase as documented.

* fix tests

* update websockets

* fix tests

* add tests

* default algoType

* update readme

* fix test id

* skip test

* fix linting

---------

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: carlosmiei <43336371+carlosmiei@users.noreply.github.com>

Author: 3 people

README.rst

@@ -166,6 +166,18 @@ pass `testnet=True` when creating the client.
     # fetch weekly klines since it listed
     klines = client.get_historical_klines("NEOBTC", Client.KLINE_INTERVAL_1WEEK, "1 Jan, 2017")
 
+    # create conditional order using the dedicated method
+    algo_order = client.futures_create_algo_order(symbol="LTCUSDT", side="BUY", type="STOP_MARKET", quantity=0.1, triggerPrice = 120)
+
+    # create conditional order using the create_order method (will redirect to the algoOrder as well)
+    order2 = await client.futures_create_order(symbol="LTCUSDT", side="BUY", type="STOP_MARKET", quantity=0.1, triggerPrice = 120)
+
+    # cancel algo/conditional order
+    cancel2 = await client.futures_cancel_algo_order(orderId=order2["orderId"], symbol="LTCUSDT")
+
+    # fetch open algo/conditional orders
+    open_orders = await client.futures_get_open_algo_orders(symbol="LTCUSDT")
+
     # create order through websockets
     order_ws = client.ws_create_order( symbol="LTCUSDT", side="BUY", type="MARKET", quantity=0.1)
 
@@ -254,6 +266,7 @@ for more information.
         # fetch weekly klines since it listed
         klines = await client.get_historical_klines("NEOBTC", Client.KLINE_INTERVAL_1WEEK, "1 Jan, 2017")
 
+
         # create order through websockets
         order_ws = await client.ws_create_order( symbol="LTCUSDT", side="BUY", type="MARKET", quantity=0.1)
 

binance/async_client.py

@@ -1888,9 +1888,32 @@ async def futures_loan_interest_history(self, **params):
         )
 
     async def futures_create_order(self, **params):
-        if "newClientOrderId" not in params:
-            params["newClientOrderId"] = self.CONTRACT_ORDER_PREFIX + self.uuid22()
-        return await self._request_futures_api("post", "order", True, data=params)
+        # Check if this is a conditional order type that needs to use algo endpoint
+        order_type = params.get("type", "").upper()
+        conditional_types = [
+            "STOP",
+            "STOP_MARKET",
+            "TAKE_PROFIT",
+            "TAKE_PROFIT_MARKET",
+            "TRAILING_STOP_MARKET",
+        ]
+
+        if order_type in conditional_types:
+            # Route to algo order endpoint
+            if "clientAlgoId" not in params:
+                params["clientAlgoId"] = self.CONTRACT_ORDER_PREFIX + self.uuid22()
+            # Remove newClientOrderId if it was added by default
+            params.pop("newClientOrderId", None)
+            params["algoType"] = "CONDITIONAL"
+            # Convert stopPrice to triggerPrice for algo orders (camelCase per API docs)
+            if "stopPrice" in params and "triggerPrice" not in params:
+                params["triggerPrice"] = params.pop("stopPrice")
+            return await self._request_futures_api("post", "algoOrder", True, data=params)
+        else:
+            # Use regular order endpoint
+            if "newClientOrderId" not in params:
+                params["newClientOrderId"] = self.CONTRACT_ORDER_PREFIX + self.uuid22()
+            return await self._request_futures_api("post", "order", True, data=params)
 
     async def futures_limit_order(self, **params):
         """Send in a new futures limit order.
@@ -1971,6 +1994,8 @@ async def futures_modify_order(self, **params):
         """
         return await self._request_futures_api("put", "order", True, data=params)
 
+    futures_modify_order.__doc__ = Client.futures_modify_order.__doc__
+
     async def futures_create_test_order(self, **params):
         return await self._request_futures_api("post", "order/test", True, data=params)
 
@@ -1987,21 +2012,66 @@ async def futures_place_batch_order(self, **params):
         )
 
     async def futures_get_order(self, **params):
-        return await self._request_futures_api("get", "order", True, data=params)
+        # Check if this is a request for a conditional/algo order
+        is_conditional = params.pop("conditional", False)
+        # Also check if algoId or clientAlgoId is provided
+        if "algoId" in params or "clientAlgoId" in params:
+            is_conditional = True
+
+        if is_conditional:
+            return await self._request_futures_api("get", "algoOrder", True, data=params)
+        else:
+            return await self._request_futures_api("get", "order", True, data=params)
+
+    futures_get_order.__doc__ = Client.futures_get_order.__doc__
 
     async def futures_get_open_orders(self, **params):
-        return await self._request_futures_api("get", "openOrders", True, data=params)
+        is_conditional = params.pop("conditional", False)
+
+        if is_conditional:
+            return await self._request_futures_api("get", "openAlgoOrders", True, data=params)
+        else:
+            return await self._request_futures_api("get", "openOrders", True, data=params)
+
+    futures_get_open_orders.__doc__ = Client.futures_get_open_orders.__doc__
 
     async def futures_get_all_orders(self, **params):
-        return await self._request_futures_api("get", "allOrders", True, data=params)
+        is_conditional = params.pop("conditional", False)
+
+        if is_conditional:
+            return await self._request_futures_api("get", "allAlgoOrders", True, data=params)
+        else:
+            return await self._request_futures_api("get", "allOrders", True, data=params)
+
+    futures_get_all_orders.__doc__ = Client.futures_get_all_orders.__doc__
 
     async def futures_cancel_order(self, **params):
-        return await self._request_futures_api("delete", "order", True, data=params)
+        # Check if this is a request for a conditional/algo order
+        is_conditional = params.pop("conditional", False)
+        # Also check if algoId or clientAlgoId is provided
+        if "algoId" in params or "clientAlgoId" in params:
+            is_conditional = True
+
+        if is_conditional:
+            return await self._request_futures_api("delete", "algoOrder", True, data=params)
+        else:
+            return await self._request_futures_api("delete", "order", True, data=params)
+
+    futures_cancel_order.__doc__ = Client.futures_cancel_order.__doc__
 
     async def futures_cancel_all_open_orders(self, **params):
-        return await self._request_futures_api(
-            "delete", "allOpenOrders", True, data=params
-        )
+        is_conditional = params.pop("conditional", False)
+
+        if is_conditional:
+            return await self._request_futures_api(
+                "delete", "algoOpenOrders", True, data=params
+            )
+        else:
+            return await self._request_futures_api(
+                "delete", "allOpenOrders", True, data=params
+            )
+            
+    futures_cancel_all_open_orders.__doc__ = Client.futures_cancel_all_open_orders.__doc__
 
     async def futures_cancel_orders(self, **params):
         if params.get("orderidlist"):
@@ -2021,6 +2091,44 @@ async def futures_countdown_cancel_all(self, **params):
             "post", "countdownCancelAll", True, data=params
         )
 
+    # Algo Orders (Conditional Orders)
+
+    async def futures_create_algo_order(self, **params):
+        if "clientAlgoId" not in params:
+            params["clientAlgoId"] = self.CONTRACT_ORDER_PREFIX + self.uuid22()
+        if "algoType" not in params:
+            params["algoType"] = "CONDITIONAL"
+        return await self._request_futures_api("post", "algoOrder", True, data=params)
+
+    futures_create_algo_order.__doc__ = Client.futures_create_algo_order.__doc__
+
+    async def futures_cancel_algo_order(self, **params):
+        return await self._request_futures_api("delete", "algoOrder", True, data=params)
+
+    futures_cancel_algo_order.__doc__ = Client.futures_cancel_algo_order.__doc__
+
+    async def futures_cancel_all_algo_open_orders(self, **params):
+        return await self._request_futures_api(
+            "delete", "algoOpenOrders", True, data=params
+        )
+    
+    futures_cancel_all_algo_open_orders.__doc__ = Client.futures_cancel_all_algo_open_orders.__doc__
+
+    async def futures_get_algo_order(self, **params):
+        return await self._request_futures_api("get", "algoOrder", True, data=params)
+
+    futures_get_algo_order.__doc__ = Client.futures_get_algo_order.__doc__
+
+    async def futures_get_open_algo_orders(self, **params):
+        return await self._request_futures_api("get", "openAlgoOrders", True, data=params)
+    
+    futures_get_open_algo_orders.__doc__ = Client.futures_get_open_algo_orders.__doc__
+
+    async def futures_get_all_algo_orders(self, **params):
+        return await self._request_futures_api("get", "allAlgoOrders", True, data=params)
+
+    futures_get_all_algo_orders.__doc__ = Client.futures_get_all_algo_orders.__doc__
+
     async def futures_account_balance(self, **params):
         return await self._request_futures_api(
             "get", "balance", True, version=3, data=params
@@ -3973,6 +4081,17 @@ async def ws_futures_account_status(self, **params):
         """
         return await self._ws_futures_api_request("account.status", True, params)
 
+    async def ws_futures_create_algo_order(self, **params):
+        if "clientAlgoId" not in params:
+            params["clientAlgoId"] = self.CONTRACT_ORDER_PREFIX + self.uuid22()
+        return await self._ws_futures_api_request("algoOrder.place", True, params)
+    ws_futures_create_algo_order.__doc__ = Client.ws_futures_create_algo_order.__doc__
+
+    async def ws_futures_cancel_algo_order(self, **params):
+        return await self._ws_futures_api_request("algoOrder.cancel", True, params)
+
+    ws_futures_cancel_algo_order.__doc__ = Client.ws_futures_cancel_algo_order.__doc__
+
     ####################################################
     # Gift Card API Endpoints
     ####################################################