Skip to content

feat: Expose option for user to edit max_queue_size in websockets, have async callbacks called in a task and update docs#1570

Merged
carlosmiei merged 24 commits intosammchardy:masterfrom
pcriadoperez:queue-fix
Apr 7, 2025
Merged

feat: Expose option for user to edit max_queue_size in websockets, have async callbacks called in a task and update docs#1570
carlosmiei merged 24 commits intosammchardy:masterfrom
pcriadoperez:queue-fix

Conversation

@pcriadoperez
Copy link
Copy Markdown
Collaborator

@pcriadoperez pcriadoperez commented Mar 30, 2025 •
edited
Loading

  • Move MAX_QUEUE_SIZE from constant to variable set by user on starting ThreadedWebsocket or BinanceWebsocket
  • Have async callbacks run in a task to better performance of slow async callbacks. (Before one had to finish before calling the next one)
  • Fix passing keys and proxy to threaded socket manager
  • Adds pytest-timeout and timeout of 60seconds for tests
  • Add tests
  • Update docs
  • Increase verbosity in test running
  • Comments coveralls: (Temporarily due to due to coveralls maintenance of April 6 2025: https://status.coveralls.io/)

@pcriadoperez pcriadoperez reopened this Mar 31, 2025
@carlosmiei carlosmiei closed this Mar 31, 2025
@carlosmiei carlosmiei reopened this Mar 31, 2025
@carlosmiei carlosmiei self-assigned this Apr 3, 2025
@carlosmiei carlosmiei closed this Apr 3, 2025
@carlosmiei carlosmiei reopened this Apr 3, 2025
@pcriadoperez pcriadoperez reopened this Apr 6, 2025
@carlosmiei carlosmiei merged commit 9dac1d4 into sammchardy:master Apr 7, 2025
6 of 7 checks passed
pcriadoperez added a commit to pcriadoperez/python-binance that referenced this pull request Mar 22, 2026
@pcriadoperez
feat: Expose option for user to edit max_queue_size in websockets, ha…
86ee6db 
…ve async callbacks called in a task and update docs (sammchardy#1570)

* add timeout to jobs

* feat: expose variable max_queue_size and have async callbacks called in a task

* fix tests

* fix proxy in test

* pass params to socket manager

* skip test in 3.7

* add pytest timeout

* improve logging and error throw on failed connection and add test

* update tests

* skip for 3.7

* pyright tests

* fix test

* comment coveralls

* add debug logging to test

* add more logigng test only file

* fix test

* run all tests

* reduce logging

* update symbol for test

* uncomment coveralls to test

* Revert "uncomment coveralls to test"

This reverts commit e759466.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosmiei carlosmiei Awaiting requested review from carlosmiei carlosmiei is a code owner

Assignees

@carlosmiei carlosmiei

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pcriadoperez @carlosmiei