fix: reconnect keep alive#1637
Merged
carlosmiei merged 2 commits intosammchardy:masterfrom Dec 5, 2025
Merged
Conversation
pcriadoperez
added a commit
to pcriadoperez/python-binance
that referenced
this pull request
Mar 22, 2026
* fix: reconnect keep alive * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a task leak in
KeepAliveWebsocketwhere reconnection events create duplicate keepalive loops that continue running indefinitely, leading to resource exhaustion and redundant API calls.Problem
The current implementation has a critical issue where the keepalive loop is not properly stopped during reconnection or cleanup:
Root Cause:
_start_socket_timer()-> (timeout delay) ->_keepalive_socket()->finally: _start_socket_timer()-> ..._after_connect(), a new loop is unconditionally started even if the previous loop is still runningConsequences:
Solution
Implement a sentinel-based approach using
self._timerto prevent duplicate loop:_after_connect(): Only start a new keepalive loop if one isn't already running_keepalive_socket()finally block: Only restart the loop if not being shut down (i.e.,self._timeris not None)This ensures:
__aexit__()setsself._timer = None, the finally block stops restarting