Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion binance/async_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -941,7 +941,7 @@ async def get_asset_details(self, **params):

async def get_spot_delist_schedule(self, **params):
return await self._request_margin_api(
"get", "/spot/delist-schedule", signed=True, data=params
"get", "/spot/delist-schedule", signed=False, data=params
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-HD Hello, if you try to open the link in the browser https://api.binance.com/sapi/v1/spot/delist-schedule

you can see you get {"code":-2014,"msg":"API-key format invalid."} meaning that the endpoint indeed requires credentials

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For spot delist schedule an API-key is necessary, that's true. But the request for this endpoint doesn't need to be signed as it is MARKET_DATA.
See: https://developers.binance.com/docs/wallet/general-info#request-security
I have tested the patch and it worked.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request is still open. It's working properly, but hasn't been included in the latest update 1.0.35.
What's the problem?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-HD Sorry I was assuming that providing signed=False would skip the APIKey in Headers (since this endpoint is an "hybrid" only requires apiKey but not signing) but that's not the case, will merge it now.

)

get_spot_delist_schedule.__doc__ = Client.get_spot_delist_schedule.__doc__
Expand Down
Loading