rename getters and mark them as const+noexcept in ValueAnimatedNode

Summary:
changelog: [internal]


rename methods to reflect that they are getters and mark them as noexcept const

Reviewed By: rshest

Differential Revision: D75217535

Author: sammy-SC

packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.cpp

@@ -72,7 +72,7 @@ NativeAnimatedNodesManager::~NativeAnimatedNodesManager() noexcept {
 std::optional<double> NativeAnimatedNodesManager::getValue(Tag tag) noexcept {
   auto node = getAnimatedNode<ValueAnimatedNode>(tag);
   if (node) {
-    return node->value();
+    return node->getValue();
   } else {
     LOG(WARNING)
         << "Cannot get value from AnimatedNode, it's not a ValueAnimatedNode";

packages/react-native/ReactCxxPlatform/react/renderer/animated/drivers/AnimationDriver.cpp

@@ -53,7 +53,7 @@ void AnimationDriver::stopAnimation(bool /*ignoreCompletedHandlers*/) {
   std::optional<double> value = std::nullopt;
   if (auto node =
           manager_->getAnimatedNode<ValueAnimatedNode>(animatedValueTag_)) {
-    value = node->value();
+    value = node->getValue();
   } else {
     LOG(ERROR)
         << "animatedValueTag should be associated with a ValueAnimatedNode";

packages/react-native/ReactCxxPlatform/react/renderer/animated/drivers/DecayAnimationDriver.cpp

@@ -45,7 +45,7 @@ bool DecayAnimationDriver::update(double timeDeltaMs, bool restarting) {
   if (const auto node =
           manager_->getAnimatedNode<ValueAnimatedNode>(animatedValueTag_)) {
     if (restarting) {
-      const auto value = node->rawValue();
+      const auto value = node->getRawValue();
       if (!fromValue_.has_value()) {
         // First iteration, assign fromValue based on AnimatedValue
         fromValue_ = value;

packages/react-native/ReactCxxPlatform/react/renderer/animated/drivers/FrameAnimationDriver.cpp

@@ -58,7 +58,7 @@ bool FrameAnimationDriver::update(double timeDeltaMs, bool /*restarting*/) {
   if (auto node =
           manager_->getAnimatedNode<ValueAnimatedNode>(animatedValueTag_)) {
     if (!startValue_) {
-      startValue_ = node->rawValue();
+      startValue_ = node->getRawValue();
     }
 
     const auto startIndex =

packages/react-native/ReactCxxPlatform/react/renderer/animated/drivers/SpringAnimationDriver.cpp

@@ -82,7 +82,7 @@ bool SpringAnimationDriver::update(double timeDeltaMs, bool restarting) {
           manager_->getAnimatedNode<ValueAnimatedNode>(animatedValueTag_)) {
     if (restarting) {
       if (!fromValue_.has_value()) {
-        fromValue_ = node->rawValue();
+        fromValue_ = node->getRawValue();
       } else {
         if (node->setRawValue(fromValue_.value())) {
           markNodeUpdated(node->tag());

packages/react-native/ReactCxxPlatform/react/renderer/animated/nodes/AdditionAnimatedNode.cpp

@@ -22,7 +22,7 @@ void AdditionAnimatedNode::update() {
     const auto node = manager_->getAnimatedNode<ValueAnimatedNode>(tag);
     react_native_assert(
         node && "Invalid node tag set as input for AdditionAnimatedNode");
-    rawValue += node->value();
+    rawValue += node->getValue();
   }
   setRawValue(rawValue);
 }

packages/react-native/ReactCxxPlatform/react/renderer/animated/nodes/ColorAnimatedNode.cpp

@@ -23,9 +23,10 @@ uint8_t getColorValue(
     bool isDecimal = false) {
   if (const auto node = manager.getAnimatedNode<ValueAnimatedNode>(nodeTag)) {
     if (isDecimal) {
-      return std::clamp(static_cast<uint32_t>(node->value() * 255), 0u, 255u);
+      return std::clamp(
+          static_cast<uint32_t>(node->getValue() * 255), 0u, 255u);
     } else {
-      return std::clamp(static_cast<uint32_t>(node->value()), 0u, 255u);
+      return std::clamp(static_cast<uint32_t>(node->getValue()), 0u, 255u);
     }
   }
   return 0;

packages/react-native/ReactCxxPlatform/react/renderer/animated/nodes/DiffClampAnimatedNode.cpp

@@ -27,10 +27,10 @@ DiffClampAnimatedNode::DiffClampAnimatedNode(
 void DiffClampAnimatedNode::update() {
   if (const auto node =
           manager_->getAnimatedNode<ValueAnimatedNode>(inputNodeTag_)) {
-    const auto value = node->value();
+    const auto value = node->getValue();
     const auto diff = value - lastValue_;
     lastValue_ = value;
-    setRawValue(std::clamp(this->value() + diff, min_, max_));
+    setRawValue(std::clamp(this->getValue() + diff, min_, max_));
   }
 }
 

packages/react-native/ReactCxxPlatform/react/renderer/animated/nodes/DivisionAnimatedNode.cpp

@@ -24,9 +24,9 @@ void DivisionAnimatedNode::update() {
     react_native_assert(
         node && "Invalid node tag set as input for DivisionAnimatedNode");
     if (count == 0) {
-      rawValue = node->value();
+      rawValue = node->getValue();
     } else {
-      rawValue /= node->value();
+      rawValue /= node->getValue();
     }
 
     count++;

packages/react-native/ReactCxxPlatform/react/renderer/animated/nodes/InterpolationAnimatedNode.cpp

@@ -54,9 +54,9 @@ void InterpolationAnimatedNode::update() {
   if (const auto node =
           manager_->getAnimatedNode<ValueAnimatedNode>(parentTag_)) {
     if (isColorValue_) {
-      setRawValue(interpolateColor(node->value()));
+      setRawValue(interpolateColor(node->getValue()));
     } else {
-      setRawValue(interpolateValue(node->value()));
+      setRawValue(interpolateValue(node->getValue()));
     }
   }
 }