mark methods as const in nodes

Summary:
changelog: [internal]


mark more methods as const and noexcept.

Reviewed By: mdvacca

Differential Revision: D75218535

Author: sammy-SC

packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.cpp

@@ -490,7 +490,7 @@ void NativeAnimatedNodesManager::updateNodes(
     nodesQueue.pop_front();
     // in Animated, value nodes like RGBA are parents and Color node is child
     // (the opposite of tree structure)
-    for (const auto childTag : nextNode.node->children()) {
+    for (const auto childTag : nextNode.node->getChildren()) {
       auto child = getAnimatedNode<AnimatedNode>(childTag);
       child->activeIncomingNodes++;
       if (child->bfsColor != animatedGraphBFSColor_) {
@@ -554,7 +554,7 @@ void NativeAnimatedNodesManager::updateNodes(
       nextNode.node->update();
     }
 
-    for (auto childTag : nextNode.node->children()) {
+    for (auto childTag : nextNode.node->getChildren()) {
       auto child = getAnimatedNode<AnimatedNode>(childTag);
       child->activeIncomingNodes--;
       if (child->activeIncomingNodes == 0 && child->activeIncomingNodes == 0) {

packages/react-native/ReactCxxPlatform/react/renderer/animated/nodes/AnimatedNode.h

@@ -54,23 +54,23 @@ class AnimatedNode {
   AnimatedNode(const AnimatedNode&) = default;
   AnimatedNode& operator=(const AnimatedNode&) = default;
 
-  Tag tag() const {
+  Tag tag() const noexcept {
     return tag_;
   }
 
   void addChild(Tag tag);
 
   void removeChild(Tag tag);
 
-  const std::unordered_set<Tag>& children() const {
+  const std::unordered_set<Tag>& getChildren() const noexcept {
     return children_;
   }
 
-  AnimatedNodeType type() const {
+  AnimatedNodeType type() const noexcept {
     return type_;
   }
 
-  const folly::dynamic& getConfig() const {
+  const folly::dynamic& getConfig() const noexcept {
     return config_;
   }
 

packages/react-native/ReactCxxPlatform/react/renderer/animated/nodes/StyleAnimatedNode.h

@@ -24,7 +24,7 @@ class StyleAnimatedNode final : public AnimatedNode {
       NativeAnimatedNodesManager& manager);
   void update() override;
 
-  const folly::dynamic& getProps() const {
+  const folly::dynamic& getProps() const noexcept {
     return props_;
   }