Commit 9aef2ba
Fix Fantom getRenderedOutput not reflecting removed props
Summary:
`RenderOutput::renderView` merged old cached props with new debug props
via `mergeDynamicProps`. Since `getDebugProps()` omits default-valued
props, removed props were never cleared from the cache. Also,
`renderedViews_.insert()` never overwrote existing entries.
Fix by reading debug props directly and using `insert_or_assign`.
Changelog: [Internal]
Differential Revision: D950557041 parent f81f73e commit 9aef2ba
File tree
2 files changed
+24
-11
lines changed- packages/react-native/Libraries/Components/View/__tests__
- private/react-native-fantom/tester/src/render
2 files changed
+24
-11
lines changedLines changed: 22 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
670 | 670 | | |
671 | 671 | | |
672 | 672 | | |
| 673 | + | |
| 674 | + | |
| 675 | + | |
| 676 | + | |
| 677 | + | |
| 678 | + | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
673 | 695 | | |
674 | 696 | | |
675 | 697 | | |
| |||
Lines changed: 2 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
61 | 60 | | |
62 | 61 | | |
63 | 62 | | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
| 63 | + | |
73 | 64 | | |
74 | 65 | | |
75 | 66 | | |
| |||
96 | 87 | | |
97 | 88 | | |
98 | 89 | | |
99 | | - | |
| 90 | + | |
100 | 91 | | |
101 | 92 | | |
102 | 93 | | |
| |||
0 commit comments