Skip to content

Commit a7b4af2

Browse files
sammy-SCfacebook-github-bot
authored andcommitted
remove enable_shared_from_this from AnimatedModule
Summary: changelog: [internal] When native module is destroyed, ui queue is also torn down. this helps with C++ binary size a little bit Reviewed By: rshest Differential Revision: D75149437
1 parent 53619b5 commit a7b4af2

2 files changed

Lines changed: 10 additions & 14 deletions

File tree

packages/react-native/ReactCxxPlatform/react/renderer/animated/AnimatedModule.cpp

Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -79,20 +79,17 @@ void AnimatedModule::getValue(
7979
void AnimatedModule::startListeningToAnimatedNodeValue(
8080
jsi::Runtime& /*rt*/,
8181
Tag tag) {
82-
addOperation([tag, weakThis = weak_from_this()](
83-
NativeAnimatedNodesManager& nodesManager) {
82+
addOperation([tag, this](NativeAnimatedNodesManager& nodesManager) {
8483
nodesManager.startListeningToAnimatedNodeValue(
85-
tag, [weakThis, tag](double value) {
86-
if (auto strongThis = weakThis.lock()) {
87-
strongThis->emitDeviceEvent(
88-
"onAnimatedValueUpdate",
89-
[tag, value](jsi::Runtime& rt, std::vector<jsi::Value>& args) {
90-
auto arg = jsi::Object(rt);
91-
arg.setProperty(rt, "tag", jsi::Value(tag));
92-
arg.setProperty(rt, "value", jsi::Value(value));
93-
args.emplace_back(rt, arg);
94-
});
95-
}
84+
tag, [this, tag](double value) {
85+
emitDeviceEvent(
86+
"onAnimatedValueUpdate",
87+
[tag, value](jsi::Runtime& rt, std::vector<jsi::Value>& args) {
88+
auto arg = jsi::Object(rt);
89+
arg.setProperty(rt, "tag", jsi::Value(tag));
90+
arg.setProperty(rt, "value", jsi::Value(value));
91+
args.emplace_back(rt, arg);
92+
});
9693
});
9794
});
9895
}

packages/react-native/ReactCxxPlatform/react/renderer/animated/AnimatedModule.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
namespace facebook::react {
1919

2020
class AnimatedModule : public NativeAnimatedModuleCxxSpec<AnimatedModule>,
21-
public std::enable_shared_from_this<AnimatedModule>,
2221
public TurboModuleWithJSIBindings {
2322
using Operation =
2423
std::function<void(NativeAnimatedNodesManager& nodesManager)>;

0 commit comments

Comments
 (0)