Merge pull request codeigniter4#7291 from kenjis/fix-phpstan-1.10.1-errors

refactor: resolove PHPStan 1.10.1 errors

Author: samsonasik

phpstan-baseline.neon.dist

@@ -20,11 +20,6 @@ parameters:
 			count: 1
 			path: system/Cache/Handlers/FileHandler.php
 
-		-
-			message: "#^Unreachable statement \\- code above always terminates\\.$#"
-			count: 1
-			path: system/Cache/Handlers/MemcachedHandler.php
-
 		-
 			message: "#^Property CodeIgniter\\\\Cache\\\\Handlers\\\\RedisHandler\\:\\:\\$redis \\(Redis\\) in isset\\(\\) is not nullable\\.$#"
 			count: 1
@@ -50,16 +45,6 @@ parameters:
 			count: 1
 			path: system/Database/BaseConnection.php
 
-		-
-			message: "#^Unreachable statement \\- code above always terminates\\.$#"
-			count: 2
-			path: system/Database/BaseResult.php
-
-		-
-			message: "#^While loop condition is always true\\.$#"
-			count: 2
-			path: system/Database/BaseResult.php
-
 		-
 			message: "#^Access to an undefined property CodeIgniter\\\\Database\\\\ConnectionInterface\\:\\:\\$DBDriver\\.$#"
 			count: 2
@@ -260,21 +245,11 @@ parameters:
 			count: 1
 			path: system/Router/Router.php
 
-		-
-			message: "#^Strict comparison using \\=\\=\\= between string and true will always evaluate to false\\.$#"
-			count: 1
-			path: system/Session/Handlers/RedisHandler.php
-
 		-
 			message: "#^Property CodeIgniter\\\\Session\\\\Session\\:\\:\\$sessionExpiration \\(int\\) in isset\\(\\) is not nullable\\.$#"
 			count: 1
 			path: system/Session/Session.php
 
-		-
-			message: "#^Negated boolean expression is always false\\.$#"
-			count: 1
-			path: system/Test/CIUnitTestCase.php
-
 		-
 			message: "#^Access to an undefined property object\\:\\:\\$createdField\\.$#"
 			count: 1

system/Commands/Utilities/Routes/ControllerFinder.php

@@ -44,6 +44,7 @@ public function find(): array
         $nsArray = explode('\\', trim($this->namespace, '\\'));
         $count   = count($nsArray);
         $ns      = '';
+        $files   = [];
 
         for ($i = 0; $i < $count; $i++) {
             $ns .= '\\' . array_shift($nsArray);