Fixes error type definition by severity for display_errors = 1

Author: samsonasik

src/Handler/Logging.php

@@ -4,6 +4,7 @@
 
 use Error;
 use ErrorException;
+use ErrorHeroModule\HeroConstant;
 use Exception;
 use Psr\Http\Message\ServerRequestInterface;
 use RuntimeException;
@@ -185,11 +186,12 @@ private function collectExceptionData($e)
     {
         $priority = Logger::ERR;
         if ($e instanceof ErrorException && isset(Logger::$errorPriorityMap[$e->getSeverity()])) {
-            $priority = Logger::$errorPriorityMap[$e->getSeverity()];
+            $priority  = Logger::$errorPriorityMap[$e->getSeverity()];
+            $errorType = HeroConstant::ERROR_TYPE[$e->getSeverity()];
+        } else {
+            $errorType = get_class($e);
         }
 
-        $exceptionClass = get_class($e);
-
         $errorFile = $e->getFile();
         $errorLine = $e->getLine();
         $trace     = $e->getTraceAsString();
@@ -202,7 +204,7 @@ private function collectExceptionData($e)
 
         return [
             'priority'       => $priority,
-            'exceptionClass' => $exceptionClass,
+            'errorType'      => $errorType,
             'errorFile'      => $errorFile,
             'errorLine'      => $errorLine,
             'trace'          => $trace,
@@ -221,7 +223,7 @@ private function collectExceptionExtraData(array $collectedExceptionData)
             'url'          => $this->serverUrl.$this->requestUri,
             'file'         => $collectedExceptionData['errorFile'],
             'line'         => $collectedExceptionData['errorLine'],
-            'error_type'   => $collectedExceptionData['exceptionClass'],
+            'error_type'   => $collectedExceptionData['errorType'],
             'trace'        => $collectedExceptionData['trace'],
             'request_data' => $this->getRequestData(),
         ];
@@ -291,7 +293,7 @@ public function handleException($e)
             $extra                  = $this->collectExceptionExtraData($collectedExceptionData);
         }
 
-        $this->sendMail($collectedExceptionData['priority'], $collectedExceptionData['errorMessage'], $extra, '['.$this->serverUrl.'] '.$collectedExceptionData['exceptionClass'].' has thrown');
+        $this->sendMail($collectedExceptionData['priority'], $collectedExceptionData['errorMessage'], $extra, '['.$this->serverUrl.'] '.$collectedExceptionData['errorType'].' has thrown');
     }
 
     /**

src/HeroConstant.php

@@ -0,0 +1,24 @@
+<?php
+
+namespace ErrorHeroModule;
+
+class HeroConstant
+{
+    const ERROR_TYPE = [
+        E_ERROR             => 'E_ERROR',
+        E_WARNING           => 'E_WARNING',
+        E_PARSE             => 'E_PARSE',
+        E_NOTICE            => 'E_NOTICE',
+        E_CORE_ERROR        => 'E_CORE_ERROR',
+        E_CORE_WARNING      => 'E_CORE_WARNING',
+        E_COMPILE_ERROR     => 'E_COMPILE_ERROR',
+        E_COMPILE_WARNING   => 'E_COMPILE_WARNING',
+        E_USER_ERROR        => 'E_USER_ERROR',
+        E_USER_WARNING      => 'E_USER_WARNING',
+        E_USER_NOTICE       => 'E_USER_NOTICE',
+        E_STRICT            => 'E_STRICT',
+        E_RECOVERABLE_ERROR => 'E_RECOVERABLE_ERROR',
+        E_DEPRECATED        => 'E_DEPRECATED',
+        E_USER_DEPRECATED   => 'E_USER_DEPRECATED',
+    ];
+}

src/HeroTrait.php

@@ -24,27 +24,6 @@ trait HeroTrait
      */
     private $renderer;
 
-    /**
-     * @var array
-     */
-    private $errorType = [
-        E_ERROR             => 'E_ERROR',
-        E_WARNING           => 'E_WARNING',
-        E_PARSE             => 'E_PARSE',
-        E_NOTICE            => 'E_NOTICE',
-        E_CORE_ERROR        => 'E_CORE_ERROR',
-        E_CORE_WARNING      => 'E_CORE_WARNING',
-        E_COMPILE_ERROR     => 'E_COMPILE_ERROR',
-        E_COMPILE_WARNING   => 'E_COMPILE_WARNING',
-        E_USER_ERROR        => 'E_USER_ERROR',
-        E_USER_WARNING      => 'E_USER_WARNING',
-        E_USER_NOTICE       => 'E_USER_NOTICE',
-        E_STRICT            => 'E_STRICT',
-        E_RECOVERABLE_ERROR => 'E_RECOVERABLE_ERROR',
-        E_DEPRECATED        => 'E_DEPRECATED',
-        E_USER_DEPRECATED   => 'E_USER_DEPRECATED',
-    ];
-
     /**
      * @var ServerRequest|null
      */
@@ -71,7 +50,7 @@ public function execOnShutdown()
      */
     public function phpErrorHandler($errorType, $errorMessage, $errorFile, $errorLine)
     {
-        $errorTypeString = $this->errorType[$errorType];
+        $errorTypeString = HeroConstant::ERROR_TYPE[$errorType];
         $errorExcluded = false;
         if ($errorLine) {
             if (in_array($errorType, $this->errorHeroModuleConfig['display-settings']['exclude-php-errors'])) {