use ErrorException to throw on display_errors = 1

Author: samsonasik

spec/Fixture/view/error.phtml

@@ -2,6 +2,7 @@
 
 namespace ErrorHeroModule\Spec\Listener;
 
+use ErrorException;
 use ErrorHeroModule\Handler\Logging;
 use ErrorHeroModule\Listener\Mvc;
 use Kahlan\Plugin\Double;
@@ -283,15 +284,12 @@
 
         it('call error_get_last() and return error', function () {
 
-            Quit::disable();
-
             allow('error_get_last')->toBeCalled()->andReturn([
                 'type' => 8,
                 'message' => 'Undefined variable: a',
                 'file' => '/var/www/zf/module/Application/Module.php',
                 'line' => 2
             ]);
-            expect('error_get_last')->toBeCalled();
 
             $dbAdapter = new Adapter([
                 'username' => 'root',
@@ -353,6 +351,7 @@
             $resolver = new Resolver\AggregateResolver();
 
             $map = new Resolver\TemplateMapResolver([
+                'error'                           => __DIR__ . '/../Fixture/view/error.phtml',
                 'layout/layout'                   => __DIR__ . '/../Fixture/view/layout/layout.phtml',
                 'error-hero-module/error-default' => __DIR__ . '/../Fixture/view/error-hero-module/error-default.phtml',
             ]);
@@ -407,14 +406,11 @@
                 $this->renderer
             );
 
-            ob_start();
             $closure = function () use ($listener) {
                 $listener->execOnShutdown();
             };
-            expect($closure)->toThrow(new QuitException('Exit statement occurred', -1));
-            $content = ob_get_clean();
-
-            expect($content)->toContain('We have encountered a problem');
+            expect($closure)->toThrow(new ErrorException('Undefined variable: a', 500, 1));
+            
 
         });
 

spec/Listener/MvcSpec.php

@@ -15,7 +15,5 @@ public function errorAction()
     {
         $array = [];
         $array[1]; // E_NOTICE
-
-        return $this->getResponse();
     }
 }

src/Controller/ErrorPreviewController.php

@@ -2,6 +2,7 @@
 
 namespace ErrorHeroModule;
 
+use ErrorException;
 use ErrorHeroModule\Handler\Logging;
 use Zend\Diactoros\ServerRequest;
 use Zend\Expressive\Template\TemplateRendererInterface;
@@ -66,13 +67,17 @@ public function phpErrorHandler($errorType, $errorMessage, $errorFile, $errorLin
             }
         }
 
-        if ($this->errorHeroModuleConfig['display-settings']['display_errors'] === 0 || $errorExcluded) {
+        if (! $this->errorHeroModuleConfig['display-settings']['display_errors'] || $errorExcluded) {
             error_reporting(E_ALL | E_STRICT);
             ini_set('display_errors', 0);
         }
 
-        if (! $errorExcluded) {
+        if (! $this->errorHeroModuleConfig['display-settings']['display_errors'] && ! $errorExcluded) {
             $this->showDefaultViewWhenDisplayErrorSetttingIsDisabled();
         }
+
+        if ($this->errorHeroModuleConfig['display-settings']['display_errors']) {
+            throw new ErrorException($errorMessage, 500, $errorType);
+        }
     }
 }