Expressive: Fixes throw Error|Exception when display_errors enabled

Author: samsonasik

spec/Integration/IntegrationViaErrorPreviewActionMiddlewareShownErrorSpec.php

@@ -83,6 +83,7 @@
                 $this->app->run($serverRequest);
             } catch (\Throwable $t) {
                 expect($t)->toBeAnInstanceOf(\Throwable::class);
+                expect($t->getMessage())->toContain('sample error preview');
             }
 
         });

src/Middleware/Expressive.php

@@ -35,6 +35,13 @@ public function __construct(
         $this->renderer              = $renderer;
     }
 
+    /**
+     * @param  ServerRequestInterface $request
+     * @param  ResponseInterface      $response
+     * @param  callable               $next
+     *
+     * @return ResponseInterface|void
+     */
     public function __invoke(ServerRequestInterface $request, ResponseInterface $response, callable $next)
     {
         if (! $this->errorHeroModuleConfig['enable']) {
@@ -69,6 +76,8 @@ public function phpError()
 
     /**
      * @param  Error|Exception $e
+     * @throws Error      when 'display_errors' config is 1 and Error has thrown
+     * @throws Exception  when 'display_errors' config is 1 and Exception has thrown
      *
      * @return void
      */
@@ -78,6 +87,10 @@ public function exceptionError($e, $request)
             $e
         );
 
+        if ($this->errorHeroModuleConfig['display-settings']['display_errors']) {
+            throw $e;
+        }
+
         $this->showDefaultViewWhenDisplayErrorSetttingIsDisabled();
     }
 

src/Middleware/Routed/Preview/ErrorPreviewAction.php

@@ -21,5 +21,7 @@ public function __invoke(ServerRequestInterface $request, ResponseInterface $res
 
         $array = [];
         $array[1]; // E_NOTICE
+
+        return $response;
     }
 }