Ensure PACKAGE_VERSION is set in the Makefile#2570
Merged
Conversation
In git repositories, this is set by expanding $(shell git describe --always --dirty). As this is not in a normal Makefile rule, failure just results in an empty variable. To check that it really was set, add a check to ensure it's not empty in the rule that builds the version.h file. Signed-off-by: Rob Davies <rmd+git@sanger.ac.uk>
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In git repositories, this is set by expanding
$(shell git describe --always --dirty).As this is not in a normal Makefile rule, failure just results in an empty variable. To check that it really was set, add a check to ensure it's not empty in the rule that builds the
version.hfile.See also samtools/samtools#2337 where failing to set this variable resulted in broken files. It's less of a problem for bcftools due as it always appends the string "+htslib" to its headers, however it's probably a good idea to catch the failue to set a value if it occurs.