Recommend 1bp SEQ with QUAL="*" as quality-unavailable.#752
Closed
jkbonfield wants to merge 2 commits intosamtools:masterfrom
Closed
Recommend 1bp SEQ with QUAL="*" as quality-unavailable.#752jkbonfield wants to merge 2 commits intosamtools:masterfrom
jkbonfield wants to merge 2 commits intosamtools:masterfrom
Conversation
The use of \textsc{cr\>lf} breaks pdfTeX 3.14159265-2.6-1.40.18.
Switching to \textsc{cr\,lf} cures it. Visually they're almost
identical and it's only a footnote anyway.
"*" is either QUAL 9, or QUAL unavailable. Made a recommendation in a footnote, mainly as an indication that the ambiguity exists. In practice it's vanishingly unlikely to matter. Fixes samtools#715
Member
|
IMHO PR #724 has the footnote in the better position, so I'll close this PR, cherry-pick the non-breaking space commit, and coalesce the best of both footnote texts over there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change is simply a footnote indicating the presence of the ambiguity and a mild recommendation, however it's not likely to make any practical difference in real-world data where even if 1bp reads exist their quality values aren't likely to be a deciding factor over their validity.
Also in attempting to build the SAM spec my latex blew up. This turns out to be due to #670 which added use of
\>for non-breaking space. Our systems here are pretty old, and latex couldn't cope with that. However in the interests of keeping the spec as easy to build as possible, I did a trivial replacement in its own commit.