Rans4x16 frees and release v1.6.3#136
Merged
Merged
Conversation
Spotted by htslib's CI tests, but oddly not by htscodecs. Fixing this is a secondary issue that will be resolved later.
Embarrassingly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I clearly need to improve the test harness to do things that are erroneous / don't fit, as somehow htslib is testing this code path. It turns out #127 had a memory leak in it when recovering from rans encoding failure.
This PR doesn't add those tests, but it's noted for something I need to fix later.