convert Runtime exceptions in the CRAM code into CRAMExceptions (also…#1557
Closed
yfarjoun wants to merge 1 commit into
Closed
convert Runtime exceptions in the CRAM code into CRAMExceptions (also…#1557yfarjoun wants to merge 1 commit into
yfarjoun wants to merge 1 commit into
Conversation
Member
|
Closing as stale, alongside its near-duplicate #1526. This predates the major rewrite of the CRAM code, and the CRAMReferenceRegion constructor and message it converts no longer exist on current master, so the change no longer applies. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… runtime)
In the cram code the code throws an IllegalArgumentException when asked about the bases when a reference was not provided. This PR changes it to a CRAMException to be more informative and consistent.