Skip to content
This repository was archived by the owner on Nov 20, 2024. It is now read-only.

Commit eaff688

Browse files
samuel-oldrasamuel-oldra
committed
Melhorias no testes unitários #4 
1 parent 0876fd4 commit eaff688

2 files changed

Lines changed: 95 additions & 40 deletions

File tree

‎DevGames.API/Tests/BoardServiceTest.cs‎

Lines changed: 48 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -23,47 +23,59 @@ public void GetAll()
2323
var boards = boardService.GetAll();
2424

2525
// Assert
26+
Assert.NotNull(boards);
27+
28+
boards.ShouldNotBeNull();
29+
2630
boardRepositoryMock.Verify(br => br.GetAll(), Times.Once);
2731
}
2832

2933
[Fact]
3034
public void GetById()
3135
{
3236
// Arrange
33-
var boardId = new Fixture().Create<int>();
37+
var addBoard = new Fixture().Create<Board>();
3438

3539
var boardRepositoryMock = new Mock<IBoardRepository>();
3640

3741
var boardService = new BoardService(boardRepositoryMock.Object);
3842

3943
// Act
40-
var board = boardService.GetById(boardId);
44+
var addedBoard = boardService.Add(addBoard);
45+
var board = boardService.GetById(addedBoard.Id);
4146

4247
// Assert
48+
Assert.NotNull(addedBoard);
49+
50+
addedBoard.ShouldNotBeNull();
51+
52+
boardRepositoryMock.Verify(br => br.Add(It.IsAny<Board>()), Times.Once);
4353
boardRepositoryMock.Verify(br => br.GetById(It.IsAny<int>()), Times.Once);
4454
}
4555

4656
[Fact]
4757
public void Add()
4858
{
4959
// Arrange
50-
var board = new Fixture().Create<Board>();
60+
var addBoard = new Fixture().Create<Board>();
5161

5262
var boardRepositoryMock = new Mock<IBoardRepository>();
5363

5464
var boardService = new BoardService(boardRepositoryMock.Object);
5565

5666
// Act
57-
var addedBoard = boardService.Add(board);
67+
var addedBoard = boardService.Add(addBoard);
5868

5969
// Assert
60-
Assert.Equal(addedBoard.GameTitle, board.GameTitle);
61-
Assert.Equal(addedBoard.Description, board.Description);
62-
Assert.Equal(addedBoard.Rules, board.Rules);
70+
Assert.NotNull(addedBoard);
71+
Assert.Equal(addedBoard.GameTitle, addBoard.GameTitle);
72+
Assert.Equal(addedBoard.Description, addBoard.Description);
73+
Assert.Equal(addedBoard.Rules, addBoard.Rules);
6374

64-
addedBoard.GameTitle.ShouldBe(board.GameTitle);
65-
addedBoard.Description.ShouldBe(board.Description);
66-
addedBoard.Rules.ShouldBe(board.Rules);
75+
addedBoard.ShouldNotBeNull();
76+
addedBoard.GameTitle.ShouldBe(addBoard.GameTitle);
77+
addedBoard.Description.ShouldBe(addBoard.Description);
78+
addedBoard.Rules.ShouldBe(addBoard.Rules);
6779

6880
boardRepositoryMock.Verify(br => br.Add(It.IsAny<Board>()), Times.Once);
6981
}
@@ -72,43 +84,58 @@ public void Add()
7284
public void Update()
7385
{
7486
// Arrange
75-
var board = new Fixture().Create<Board>();
87+
var addBoard = new Fixture().Create<Board>();
7688
var updateBoardInputModel = new Fixture().Create<UpdateBoardInputModel>();
7789

7890
var boardRepositoryMock = new Mock<IBoardRepository>();
7991

8092
var boardService = new BoardService(boardRepositoryMock.Object);
8193

8294
// Act
83-
var addedBoard = boardService.Add(board);
95+
var addedBoard = boardService.Add(addBoard);
8496
var updatedBoard = boardService.Update(addedBoard, updateBoardInputModel);
8597

8698
// Assert
87-
Assert.Equal(updatedBoard.GameTitle, board.GameTitle);
88-
Assert.Equal(updatedBoard.Description, board.Description);
89-
Assert.Equal(updatedBoard.Rules, board.Rules);
90-
91-
updatedBoard.GameTitle.ShouldBe(board.GameTitle);
92-
updatedBoard.Description.ShouldBe(board.Description);
93-
updatedBoard.Rules.ShouldBe(board.Rules);
99+
Assert.NotNull(addedBoard);
100+
Assert.NotNull(updatedBoard);
101+
Assert.Equal(updatedBoard.GameTitle, addBoard.GameTitle);
102+
Assert.Equal(updatedBoard.Description, updateBoardInputModel.Description);
103+
Assert.Equal(updatedBoard.Rules, updateBoardInputModel.Rules);
104+
105+
addedBoard.ShouldNotBeNull();
106+
updatedBoard.ShouldNotBeNull();
107+
updatedBoard.GameTitle.ShouldBe(addBoard.GameTitle);
108+
updatedBoard.Description.ShouldBe(updateBoardInputModel.Description);
109+
updatedBoard.Rules.ShouldBe(updateBoardInputModel.Rules);
94110

111+
boardRepositoryMock.Verify(br => br.Add(It.IsAny<Board>()), Times.Once);
95112
boardRepositoryMock.Verify(br => br.Update(It.IsAny<Board>()), Times.Once);
96113
}
97114

98115
[Fact]
99116
public void BoardExists()
100117
{
101118
// Arrange
102-
var boardId = new Fixture().Create<int>();
119+
var addBoard = new Fixture().Create<Board>();
103120

104121
var boardRepositoryMock = new Mock<IBoardRepository>();
105122

106123
var boardService = new BoardService(boardRepositoryMock.Object);
107124

108125
// Act
109-
var boardExists = boardService.BoardExists(boardId);
126+
var addedBoard = boardService.Add(addBoard);
127+
var boardExists = boardService.BoardExists(addedBoard.Id);
110128

111129
// Assert
130+
Assert.NotNull(addedBoard);
131+
132+
addedBoard.ShouldNotBeNull();
133+
134+
// TODO: Verify if board exists
135+
// Assert.True(boardExists);
136+
// boardExists.ShouldBe(true);
137+
138+
boardRepositoryMock.Verify(br => br.Add(It.IsAny<Board>()), Times.Once);
112139
boardRepositoryMock.Verify(br => br.BoardExists(It.IsAny<int>()), Times.Once);
113140
}
114141
}

‎DevGames.API/Tests/PostServiceTest.cs‎

Lines changed: 47 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -25,50 +25,61 @@ public void GetAllByBoard()
2525
var posts = postService.GetAllByBoard(boardId);
2626

2727
// Assert
28+
Assert.NotNull(posts);
29+
30+
posts.ShouldNotBeNull();
31+
2832
postRepositoryMock.Verify(pr => pr.GetAllByBoard(It.IsAny<int>()), Times.Once);
2933
}
3034

3135
[Fact]
3236
public void GetById()
3337
{
3438
// Arrange
35-
var boardId = new Fixture().Create<int>();
36-
var postId = new Fixture().Create<int>();
39+
var addPost = new Fixture().Create<Post>();
3740

3841
var postRepositoryMock = new Mock<IPostRepository>();
3942

4043
var postService = new PostService(postRepositoryMock.Object);
4144

4245
// Act
43-
var post = postService.GetById(boardId, postId);
46+
var addedPost = postService.Add(addPost);
47+
var post = postService.GetById(addedPost.BoardId, addedPost.Id);
4448

4549
// Assert
50+
Assert.NotNull(addedPost);
51+
52+
addedPost.ShouldNotBeNull();
53+
54+
postRepositoryMock.Verify(pr => pr.Add(It.IsAny<Post>()), Times.Once);
4655
postRepositoryMock.Verify(pr => pr.GetById(It.IsAny<int>(), It.IsAny<int>()), Times.Once);
4756
}
4857

4958
[Fact]
5059
public void Add()
5160
{
5261
// Arrange
53-
var post = new Fixture().Create<Post>();
62+
var addPost = new Fixture().Create<Post>();
5463

5564
var postRepositoryMock = new Mock<IPostRepository>();
5665

5766
var postService = new PostService(postRepositoryMock.Object);
5867

5968
// Act
60-
var addedPost = postService.Add(post);
69+
var addedPost = postService.Add(addPost);
6170

6271
// Assert
63-
Assert.Equal(addedPost.Title, post.Title);
64-
Assert.Equal(addedPost.Description, post.Description);
65-
Assert.Equal(addedPost.BoardId, post.BoardId);
66-
Assert.Equal(addedPost.CreatedAt, post.CreatedAt);
67-
68-
addedPost.Title.ShouldBe(post.Title);
69-
addedPost.Description.ShouldBe(post.Description);
70-
addedPost.BoardId.ShouldBe(post.BoardId);
71-
addedPost.CreatedAt.ShouldBe(post.CreatedAt);
72+
Assert.NotNull(addedPost);
73+
Assert.Equal(addedPost.Title, addPost.Title);
74+
Assert.Equal(addedPost.Description, addPost.Description);
75+
Assert.Equal(addedPost.BoardId, addPost.BoardId);
76+
Assert.Equal(addedPost.CreatedAt, addPost.CreatedAt);
77+
78+
addedPost.ShouldNotBeNull();
79+
addedPost.Title.ShouldBe(addPost.Title);
80+
addedPost.Description.ShouldBe(addPost.Description);
81+
addedPost.BoardId.ShouldBe(addPost.BoardId);
82+
addedPost.CreatedAt.ShouldBe(addPost.CreatedAt);
7283

7384
postRepositoryMock.Verify(pr => pr.Add(It.IsAny<Post>()), Times.Once);
7485
}
@@ -77,43 +88,60 @@ public void Add()
7788
public void AddComment()
7889
{
7990
// Arrange
80-
var postId = new Fixture().Create<int>();
91+
var addPost = new Fixture().Create<Post>();
8192
var addCommentInputModel = new Fixture().Create<AddCommentInputModel>();
8293

8394
var postRepositoryMock = new Mock<IPostRepository>();
8495

8596
var postService = new PostService(postRepositoryMock.Object);
8697

8798
// Act
88-
var addedComment = postService.AddComment(postId, addCommentInputModel);
99+
var addedPost = postService.Add(addPost);
100+
var addedComment = postService.AddComment(addedPost.Id, addCommentInputModel);
89101

90102
// Assert
103+
Assert.NotNull(addedPost);
104+
Assert.NotNull(addedComment);
91105
Assert.Equal(addedComment.Title, addCommentInputModel.Title);
92106
Assert.Equal(addedComment.Description, addCommentInputModel.Description);
93107
Assert.Equal(addedComment.User, addCommentInputModel.User);
108+
Assert.Equal(addedComment.PostId, addedPost.Id);
94109

110+
addedPost.ShouldNotBeNull();
111+
addedComment.ShouldNotBeNull();
95112
addedComment.Title.ShouldBe(addCommentInputModel.Title);
96113
addedComment.Description.ShouldBe(addCommentInputModel.Description);
97114
addedComment.User.ShouldBe(addCommentInputModel.User);
115+
addedComment.PostId.ShouldBe(addedPost.Id);
98116

117+
postRepositoryMock.Verify(pr => pr.Add(It.IsAny<Post>()), Times.Once);
99118
postRepositoryMock.Verify(pr => pr.AddComment(It.IsAny<Comment>()), Times.Once);
100119
}
101120

102121
[Fact]
103122
public void PostExists()
104123
{
105124
// Arrange
106-
var boardId = new Fixture().Create<int>();
107-
var postId = new Fixture().Create<int>();
125+
var addPost = new Fixture().Create<Post>();
108126

109127
var postRepositoryMock = new Mock<IPostRepository>();
110128

111129
var postService = new PostService(postRepositoryMock.Object);
112130

113131
// Act
114-
var postExists = postService.PostExists(boardId, postId);
132+
var addedPost = postService.Add(addPost);
133+
var postExists = postService.PostExists(addedPost.BoardId, addedPost.Id);
115134

116135
// Assert
136+
Assert.NotNull(addedPost);
137+
138+
addedPost.ShouldNotBeNull();
139+
140+
// TODO: Verify if post exists
141+
// Assert.True(postExists);
142+
// postExists.ShouldBe(true);
143+
144+
postRepositoryMock.Verify(pr => pr.Add(It.IsAny<Post>()), Times.Once);
117145
postRepositoryMock.Verify(pr => pr.PostExists(It.IsAny<int>(), It.IsAny<int>()), Times.Once);
118146
}
119147
}

0 commit comments

Comments
 (0)