Validate Fiber quantum values#1
Draft
FletcherDares wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds shared validation for Fiber quantum inputs so both Fiber.new(quantum:) and Fiber#quantum= reject invalid values consistently.\n\nChanges:\n- Reject Float values instead of truncating them through NUM2UINT.\n- Reject non-positive values before unsigned conversion so negative values do not wrap.\n- Preserve RangeError for values outside the uint32 storage range.\n- Add coverage in test/ruby/test_fiber.rb and spec/ruby/core/fiber/quantum_spec.rb.\n\nVerification:\n- make -j8 miniruby\n- make test-all TESTS='../ruby-pr-16886/test/ruby/test_fiber.rb -n /quantum/'\n- make test-spec SPECOPTS=../ruby-pr-16886/spec/ruby/core/fiber/quantum_spec.rb
DRAFT!!!!