Skip to content

Commit 9f2eb46

Browse files
samuelho-devclaude
andauthored
ci: gate on patched attw instead of advisory workaround (#42)
@arethetypeswrong/core crashes ("Cannot read properties of undefined (reading 'filename')") on tarballs that gunzip into multiple chunks — its extractTarball overwrites `unzipped` per streaming chunk instead of concatenating, so untar gets the last (empty) chunk and returns zero files. Root-caused and fixed upstream (arethetypeswrong/arethetypeswrong.github.io#263). Pin @arethetypeswrong/cli as a dev dep and apply the same fix via a bun patch on @arethetypeswrong/core, so CI runs the patched local binary (`bun run attw`) instead of npx-latest. Reverts the advisory `|| echo` workaround from #41 — attw gates the package again. Drop the patch + pin and return to npx once the upstream fix is released. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent dc822e7 commit 9f2eb46

4 files changed

Lines changed: 141 additions & 22 deletions

File tree

.github/workflows/ci.yml

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -48,18 +48,16 @@ jobs:
4848

4949
- name: Verify package
5050
run: |
51-
# publint is the gating export validator.
5251
npx --yes publint
5352
54-
# are-the-types-wrong is advisory: current releases crash internally
55-
# ("Cannot read properties of undefined (reading 'filename')") on this
56-
# package's ESM-only multi-subpath exports, regardless of version or a
57-
# clean rebuild. publint already confirms the exports are valid, so an
58-
# attw crash must not fail the build. Re-enable gating once the upstream
59-
# bug is fixed (https://github.com/arethetypeswrong/arethetypeswrong.github.io).
53+
# Use the locally installed (pinned + patched) attw, NOT npx-latest.
54+
# Upstream @arethetypeswrong/core crashes ("Cannot read properties of
55+
# undefined (reading 'filename')") on tarballs that gunzip into multiple
56+
# chunks; fixed via patches/@arethetypeswrong%2Fcore@0.18.2.patch (upstream
57+
# PR: arethetypeswrong/arethetypeswrong.github.io#263). attw gates again —
58+
# drop the patch + pin and return to `npx --yes` once the fix is released.
6059
# ESM-only package: don't require CJS support, and ignore node10.
61-
npx --yes @arethetypeswrong/cli --pack . --profile node16 --ignore-rules cjs-resolves-to-esm || \
62-
echo "::warning::attw check skipped (known upstream crash); publint passed"
60+
bun run attw --pack . --profile node16 --ignore-rules cjs-resolves-to-esm
6361
6462
coverage:
6563
name: Coverage

0 commit comments

Comments
 (0)