ci: drop attw, keep publint#43
Conversation
@arethetypeswrong/cli crashes ("Cannot read properties of undefined (reading
'filename')") decompressing this package's tarball — its core overwrites the
fflate Gunzip output per chunk instead of concatenating, so any package large
enough to stream in multiple chunks (ours: 341KB/92 files) loses all but the
last empty chunk. That's a checker bug, not a problem with the generated package.
Rather than carry a local patch + pinned dep for a third-party tool, drop attw
entirely. publint remains the gating export validator. Removes the pinned
@arethetypeswrong/cli dev dep, the bun patch, and the attw script/CI step added
in #41/#42.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Disabled knowledge base sources:
📝 WalkthroughWalkthroughThe PR replaces the ChangesPackage Verification Tool Migration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removes attw from CI entirely (reverting the #41 advisory workaround and #42 local-patch machinery).
attw crashes decompressing this package's tarball — its core overwrites the fflate Gunzip output per chunk instead of concatenating, so any package that streams in multiple chunks (this one: 341 KB → fflate emits
[341504, 0, 0], last chunk kept = empty → 0 files → crash). That's a checker-tool bug; the generated package itself is valid (verified:untarof the concatenated output = 92 files, matchestar tzf).Carrying a pinned dep + local patch for a third-party tool isn't worth it. publint stays as the gating export validator ("All good!"). Drops: the
@arethetypeswrong/clidev dep, the bun patch +patchedDependencies, theattwscript, and the attw CI step.Summary by CodeRabbit
Release Notes