feat: validate JS Recon endpoints before graph ingest#137
Merged
samugit83 merged 1 commit intoJun 26, 2026
Merged
Conversation
samugit83
added a commit
that referenced
this pull request
Jun 27, 2026
…cy dial Follow-up to #137. Endpoint validation now defaults OFF and only drops endpoints a probe positively confirmed dead, so the out-of-the-box graph ingestion behavior is unchanged while probing becomes an explicit opt-in. - Default off: JS_RECON_VALIDATE_ENDPOINTS / jsReconValidateEndpoints now default to false across recon DEFAULT_SETTINGS, the validator's inline fallback, the Prisma schema, the DB column, the UI toggle, and the orchestrator /defaults endpoint. - Fix fail-closed filter: the graph mixin now drops only 'not_hittable' endpoints and ingests 'hittable' + 'unvalidated' (and missing status). Without this, disabling probing — now the default — would have silently excluded every extracted endpoint from the graph. - Add JS_RECON_ENDPOINT_CONCURRENCY / jsReconEndpointConcurrency (default 10, clamped 1-20): a parallelism dial for endpoint probes, independent of the shared JS_RECON_CONCURRENCY used by downloads/secret validation. Wired through recon settings, the probe, Prisma, the preset schema + parameter catalog, and a UI number input. Also surfaced in the recon effective-settings log. - Tests: update graph-ingestion expectations to the drop-only-dead semantics and add coverage for unvalidated endpoints being ingested when probing is off. - Drive-by: fix two pre-existing RECON_PARAMETER_CATALOG lines (jsluiceVerifyAcceptStatus / jsluiceExcludePatterns) that used "array of integers/strings" and failed the type-annotation test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Component(s)
How to Test
python -m py_compile recon\\main_recon_modules\\js_recon.py recon\\project_settings.py graph_db\\mixins\\recon\\js_recon_mixin.py recon\\tests\\test_js_recon.py tests\\test_js_recon_graph_ingestion.py.python -m unittest tests.test_js_recon_graph_ingestion -q.git diff --check master..HEAD.python recon\\tests\\test_js_recon.py,npm run type-checkinwebapp/, andnpx --yes vitest run src/lib/recon-preset-schema.test.tsinwebapp/.Checklist
docker composeScreenshots
Not included.
Related Issues
Relates to JS Recon graph pollution from unreachable extracted endpoints.