Support passing demo API key [BREAKING CHANGE]#45
Open
bahaa-kallas wants to merge 9 commits intosamuraitruong:mainfrom
Open
Support passing demo API key [BREAKING CHANGE]#45bahaa-kallas wants to merge 9 commits intosamuraitruong:mainfrom
bahaa-kallas wants to merge 9 commits intosamuraitruong:mainfrom
Conversation
Author
|
@samuraitruong would really appreciate a review of these changes. I will happily apply any requested changes. Best regards |
|
I'd really appreciate getting this merge-ready again. I upgraded to coingecko-api-v3 in my API project but forgot to rebuild it. Hours later, after finally rebuilding, I spent about an hour troubleshooting mysterious 400 errors from CoinGecko. It would be helpful to have a debug mode that displays the actual error codes and messages from CoinGecko's API. After adding HTTP middleware to inspect the actual API calls, I discovered the issue: when I provided my demo key, the library was attempting to use the pro API endpoint, which CoinGecko throws an error if used in conjunction with demo key - thus what brings me here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable passing demo API key to the client. This change is a breaking change but as the library is pre 1.0.0 stage I will leave the versioning up to the library author to decide how to proceed.