Skip to content

update for sort-dropdown to address accessiblity issues.#7296

Open
trmccormick wants to merge 5 commits into
mainfrom
feature/sort-label-i18n-fix
Open

update for sort-dropdown to address accessiblity issues.#7296
trmccormick wants to merge 5 commits into
mainfrom
feature/sort-label-i18n-fix

Conversation

@trmccormick
Copy link
Copy Markdown
Contributor

Fixes

Fixes #7235 ; refs #7235

Summary

Improve accessibility and localization of sort dropdowns in the search interface.

Guidance for testing, such as acceptance criteria or new user interface behaviors:

  • Sort dropdowns now use descriptive, internationalized labels instead of icons.
  • All sort options are clearly labeled and accessible to screen readers.
  • Sort labels are consistent across all supported locales.
  • No runtime errors occur when rendering sort fields.

Type of change (for release notes)

notes-bugfix Bug Fixes

Detailed Description

This PR updates the sort dropdowns in the search interface to enhance accessibility and localization:

  • Replaces triangle icons with text labels for sort options.
  • Uses i18n translation keys for all sort labels.
  • Ensures translation keys are present in all major locale files.
  • Fixes runtime error caused by lambda usage in Blacklight sort configuration.

Changes proposed in this pull request:

  • Update sort field configuration to use direct i18n string lookups.
  • Add missing translation keys for sort labels to all major locale files.
  • Remove lambda usage from sort label configuration to resolve runtime error.

@samvera/hyrax-code-reviewers

@trmccormick trmccormick requested a review from nhomenda December 3, 2025 23:02
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2025

Test Results

    17 files  ±0      17 suites  ±0   3h 27m 45s ⏱️ -52s
 7 552 tests  - 1   7 243 ✅  - 3  306 💤 ±0  3 ❌ +2 
25 534 runs  ±0  24 935 ✅  - 5  593 💤 ±0  6 ❌ +5 

For more details on these failures, see this check.

Results for commit 494c745. ± Comparison against base commit c2b18e5.

This pull request removes 450 and adds 449 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f42a9f694e0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f6cbdce4b00>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f6d58948348>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f8d55ab0f10>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f42a9f8b900>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f6cbe2bc320>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f6d5898a3d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f8d55aeb908>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: f31ce0b4-9efd-4439-95f9-01c56404fd0a
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 50dfde76-5265-4cd1-ac90-8ce9cc81c1e5
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007efdf282b7d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f9a10dce748>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fd186abd5d8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fd639aaf160>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007efdf286cbc0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f9a112b2bd8>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fd186d0d360>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fd639b38988>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 88380097-9cac-43f9-bd30-295252aa5fb0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 7598a723-c5ef-4781-81df-42c9bd195dca
…

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public catalog view sort-dropdown options need accessible labels for screen readers

2 participants