Skip to content

docs: document file ingest and characterization flows#7437

Merged
dlpierce merged 3 commits into
samvera:mainfrom
orangewolf:docs/file-ingest-characterization
May 22, 2026
Merged

docs: document file ingest and characterization flows#7437
dlpierce merged 3 commits into
samvera:mainfrom
orangewolf:docs/file-ingest-characterization

Conversation

@orangewolf
Copy link
Copy Markdown
Member

Summary

  • Adds documentation/file-ingest-characterization.md — a developer-oriented reference covering the complete file ingest, characterization, and derivative-generation pipeline in Hyrax.
  • Documents both the ActiveFedora actor-stack path (actors → AttachFilesToWorkJobFileSetActorIngestJobFileActorCharacterizeJobCreateDerivativesJob) and the Valkyrie transaction path (WorkCreate transaction → Steps::AddFileSetsWorkUploadsHandlerValkyrieIngestJobValkyrieUploadValkyrieCharacterizationJobValkyrieCreateDerivativesJob).
  • Covers the event system (Dry::Events/Hyrax.publisher) that decouples ingest stages in the Valkyrie path.
  • Documents Wings as the AF ↔ Valkyrie bridge and the dispatch points where the two paths diverge (AttachFilesToWorkJob, FileListener).
  • Includes concrete class/file references, configuration knobs, and a Developer Cautions section on known footguns (characterization metadata clearing, io.use_valkyrie = false, idempotency guard gaps, disk_path requirements, listener registration).

Verification

  • All source files referenced in the doc were confirmed to exist in the repo via glob/grep before committing.
  • git diff --check on the new file returned no whitespace errors.
  • No application code was modified; this is documentation only.

Commands to verify

# Confirm file exists
ls documentation/file-ingest-characterization.md

# Spot-check key source references
ls app/actors/hyrax/actors/file_actor.rb
ls app/jobs/valkyrie_ingest_job.rb
ls app/services/hyrax/work_uploads_handler.rb
ls lib/hyrax/transactions/steps/add_file_sets.rb
ls app/services/hyrax/listeners/file_listener.rb

🤖 Generated with Claude Code

Add documentation describing the complete file ingest, characterization,
and derivative-generation pipelines for both the ActiveFedora (actor-stack)
and Valkyrie (transaction/persister) back-ends. Covers key classes, entry
points, event-system wiring, Wings bridging, configuration knobs, and
developer cautions about divergent behaviour between the two paths.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Test Results

1 869 tests   1 869 ✅  0s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit 93a8ba3.

♻️ This comment has been updated with latest results.

@orangewolf orangewolf marked this pull request as ready for review May 20, 2026 00:19
Copy link
Copy Markdown
Member

@dlpierce dlpierce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@dlpierce dlpierce merged commit f62afa4 into samvera:main May 22, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants