Skip to content

Commit 4bef57f

Browse files
committed
[types] fix Collection.filterBy value argument
1 parent 3d97fb8 commit 4bef57f

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

types/collection-test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ b.items.mapBy('a'); // $ExpectType any[]
2828
b.items.mapBy('text'); // $ExpectType any[]
2929
b.items.filterBy('a'); // $ExpectType Component<{ a: number; }>[]
3030
b.items.filterBy('value'); // $ExpectType Component<{ a: number; }>[]
31+
b.items.filterBy('value', ''); // $ExpectType Component<{ a: number; }>[]
3132
b.items.findOne((a) => a.a === 1); // $ExpectType Component<{ a: number; }>
3233
b.items.findOneBy('value', 1); // $ExpectType Component<{ a: number; }>
3334
b.items.forEach((node, _i: number) => {

types/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ declare module 'ember-cli-page-object' {
4545
[Symbol.iterator](): Iterator<Component<T>>;
4646

4747
filter(callback: (c: Component<T>) => boolean): Array<Component<T>>;
48-
filterBy(propName: keyof T | keyof DSL<T>): Array<Component<T>>;
48+
filterBy(propName: keyof T | keyof DSL<T>, value?: any): Array<Component<T>>;
4949
findOne(callback: (c: Component<T>) => boolean): Component<T>;
5050
findOneBy(propName: keyof T | keyof DSL<T>, value: any): Component<T>;
5151
forEach(callback: (c: Component<T>, i: number) => void): void;

0 commit comments

Comments
 (0)