fix: critical security vulnerabilities#1
Open
peleg-development wants to merge 1 commit into
Open
Conversation
- Remove role from registration request body (privilege escalation) - Add authentication to user listing routes - Escape regex special characters in query filters (ReDoS) - Enable helmet middleware for security headers - Restrict user role field to enum values - Remove console.log leaking request body with passwords - Remove role from login response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fixes
Critical
rolefrom accepted registration fields. Previously, any user could register as admin by sending{"role": "admin"}in the request body.verifyUsermiddleware toGET /api/usersandGET /api/users/:id. These routes were publicly accessible without any authentication.Medium
helmetmiddleware (was imported but never used).console.log(req.body)from registration handler that logged passwords in plaintext.["user", "admin"]enum to prevent arbitrary role values.rolefield from login response to avoid exposing internal role structure.