Skip to content

Y26-129 - Tidy sample manifests#5796

Open
StephenHulme wants to merge 17 commits into
developfrom
sh51/tidy-manifests
Open

Y26-129 - Tidy sample manifests#5796
StephenHulme wants to merge 17 commits into
developfrom
sh51/tidy-manifests

Conversation

@StephenHulme
Copy link
Copy Markdown
Contributor

@StephenHulme StephenHulme commented May 20, 2026

Small refactors and changes to sample manifests in preparation for #5797

Changes proposed in this pull request

  • Encapsulate functions in update_sample
  • Move sample manifest barcodes into their own config file
  • Use a single sample manifest upload template and side links
  • Record manifest name with same event data
  • Allow specialised fields to known their name
  • Clarify docstrings and list formatting
  • Move i5,i7 checks to private methods
  • Remove rubocop todos

Instructions for Reviewers

[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to main]
    - Check story numbers included
    - Check for debug code
    - Check version

@StephenHulme StephenHulme changed the title [dev] Tidy sample manifests Y26-129 - Tidy sample manifests May 20, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.29%. Comparing base (6bdbfe3) to head (7ef238c).

Files with missing lines Patch % Lines
app/models/event/plate_creation_event.rb 0.00% 0 Missing and 2 partials ⚠️
app/models/event/sample_logistics_qc_event.rb 0.00% 0 Missing and 1 partial ⚠️
app/models/event/sample_manifest_event.rb 66.66% 0 Missing and 1 partial ⚠️
lib/event_factory.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5796      +/-   ##
===========================================
- Coverage    87.31%   87.29%   -0.02%     
===========================================
  Files         1480     1480              
  Lines        33637    33643       +6     
  Branches      3569     3568       -1     
===========================================
+ Hits         29369    29370       +1     
- Misses        4247     4248       +1     
- Partials        21       25       +4     
Flag Coverage Δ
javascript 76.31% <ø> (ø)
ruby 87.30% <87.17%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StephenHulme StephenHulme force-pushed the sh51/tidy-manifests branch from 4892fb0 to 7ef238c Compare May 29, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant