Skip to content

fix(deps): update dependency react-photo-album to v3 #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
squiggler-app wants to merge 2 commits into from
Closed

fix(deps): update dependency react-photo-album to v3 #1387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00ac246
fix(deps): update dependency react-photo-album to v3
squiggler-app[bot] Jul 14, 2026
3b315c0
chore(deps): changeset for dependency update
squiggler-app[bot] Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dependencies-GH-1387.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"sanity-plugin-shopify-assets": patch
---

fix(deps): update dependency react-photo-album to v3
2 changes: 1 addition & 1 deletion plugins/sanity-plugin-shopify-assets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"pretty-bytes": "^6.1.1",
"pretty-ms": "^8.0.0",
"react-infinite-scroll-component": "^6.1.1",
"react-photo-album": "^2.4.1",
"react-photo-album": "^3.6.0",

@cursor cursor Bot Jun 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing v3 album migration

High Severity

This commit raises react-photo-album to v3, but ShopifyAssetPicker still uses the v2 API (PhotoAlbum, layout, renderPhoto, componentsProps.containerProps) and never imports react-photo-album/rows.css. v3 requires layout components, the render API, updated componentsProps, and the stylesheet, so the Shopify asset grid can fail to build or render incorrectly.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 37343e2. Configure here.

"rxjs": "catalog:",
"video.js": "catalog:"
},
Expand Down
14 changes: 2 additions & 12 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading