Move turbo/**/*.hbs oxfmt ignore to root config#1604
Draft
stipsan wants to merge 1 commit into
Draft
Conversation
The turbo generator template ignore is monorepo-specific and should not ship in the shared @sanity/plugin-kit/oxfmt preset consumed by standalone plugins.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 39d7225 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the
turbo/**/*.hbsoxfmt ignore pattern out of the shared@sanity/plugin-kit/oxfmtpreset and into the monorepo rootoxfmt.config.ts.The plugin-kit preset should only contain formatting rules and ignore patterns that apply broadly to Sanity plugins (like
dist/**andpnpm-lock.yaml). Turbo generator Handlebars templates are specific to this monorepo's scaffolding setup.Changes
packages/@sanity/plugin-kit/src/oxfmt.ts: Removeturbo/**/*.hbsfromignorePatternsoxfmt.config.ts: Spread the plugin-kit preset and add the monorepo-specific ignore (mirrors howoxlint.config.tshandles workspace-specific patterns)AGENTS.md: Document that rootoxfmt.config.tsextends the preset with workspace-specific ignoresTesting
pnpm formatpnpm lint