feat: add omnisearch availablity to document Internationalization#893
Open
RobbertST wants to merge 4 commits into
Open
feat: add omnisearch availablity to document Internationalization#893RobbertST wants to merge 4 commits into
RobbertST wants to merge 4 commits into
Conversation
|
@RobbertLStevens is attempting to deploy a commit to the Sanity Sandbox Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: db3659c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Thanks @RobbertST, nice addition! Would you mind sorting out this failing test? |
* Default value was changed to true * Added case for value false
Author
|
Updated tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added Omnisearch visibility support for the
translation.metadatadocument schema via themetadataOmnisearchVisibilityplugin option.This defaults to
true, so metadata documents are still visible from global search unless users explicitly sets withmetadataOmnisearchVisibility: false.This lets users decide whether internal translation metadata documents should appear in Omnisearch.
What to review
Review the new
metadataOmnisearchVisibilityconfig option, its default value, and how it is passed into the metadata schema as__experimental_omnisearch_visibility.Affected areas:
translation.metadataschema generationTesting
Added schema tests covering:
truefalse