2.0.5 : Check for unbalanced square brackets or a space and log an error

Author: sarbian

Properties/AssemblyInfo.cs

@@ -17,7 +17,7 @@
 // The form "{Major}.{Minor}.*" will automatically update the build and revision,
 // and "{Major}.{Minor}.{Build}.*" will update just the revision.
 
-[assembly: AssemblyVersion("2.0.4")]
+[assembly: AssemblyVersion("2.0.5")]
 
 // The following attributes are used to specify the signing key for the assembly, 
 // if desired. See the Mono documentation for more information about signing.

moduleManager.cs

@@ -52,6 +52,28 @@ public static ConfigNode FindConfigNodeIn(ConfigNode src, string nodeType,
             }
             return null;
         }
+
+        public static bool IsBraquetBalanced(String str)
+        {
+            Stack<char> stack = new Stack<char>();
+
+            char c;
+            for (int i = 0; i < str.Length; i++)
+            {
+                c = str[i];
+                if (c == '[')
+                    stack.Push(c);
+                else if (c == ']')
+                    if (stack.Count == 0)
+                        return false;
+                    else if (stack.Peek() == '[' )
+                        stack.Pop();
+                    else
+                        return false;
+            }
+            return stack.Count == 0;
+        }
+
         // Added that to prevent a crash in KSP 'CopyTo' when a subnode has an empty name like
         // Like a pair of curly bracket without a name before them
         public static bool IsSane(ConfigNode node)
@@ -149,6 +171,14 @@ public static ConfigNode ModifyNode(ConfigNode original, ConfigNode mod)
             foreach (ConfigNode subMod in mod.nodes)
             {
                 subMod.name = RemoveWS(subMod.name);
+
+                if (!IsBraquetBalanced(subMod.name))
+                {
+                    print("[ModuleManager] Skipping a patch subnode with unbalanced square brackets or a space (replace them with a '?') in " + mod.name + " : \n" + subMod.name + "\n");
+                    errorCount++;
+                    continue;
+                }
+
                 char cmd = subMod.name[0];
                 if (cmd != '@' && cmd != '!' && cmd != '%' && cmd != '$')
                     newNode.AddNode(subMod);
@@ -293,7 +323,8 @@ public static ConfigNode ModifyNode(ConfigNode original, ConfigNode mod)
 
         bool loaded = false;
 
-        int patchCount = 0;
+        static int patchCount = 0;
+        static int errorCount = 0;
         List<AssemblyName> mods;
 
         public void OnGUI()
@@ -314,7 +345,7 @@ public void OnGUI()
             }
              */
 
-                        
+            
 
             if (!GameDatabase.Instance.IsReady() && ((HighLogic.LoadedScene == GameScenes.MAINMENU) || (HighLogic.LoadedScene == GameScenes.SPACECENTER)))
             {
@@ -324,6 +355,9 @@ public void OnGUI()
             if (loaded)
                 return;
 
+            patchCount = 0;
+            errorCount = 0;
+
             // Check for old version and MMSarbianExt
             var oldMM = AssemblyLoader.loadedAssemblies.Where(a => a.assembly.GetName().Name == Assembly.GetExecutingAssembly().GetName().Name).Where(a => a.assembly.GetName().Version.CompareTo(new System.Version(1, 6)) == -1);
             var oldAssemblies = oldMM.Concat(AssemblyLoader.loadedAssemblies.Where(a => a.assembly.GetName().Name == "MMSarbianExt"));
@@ -425,7 +459,7 @@ public void OnGUI()
             // :Final node
             ApplyPatch(excludePaths, ":FINAL");
 
-            print("[ModuleManager] Applied " + patchCount + " patches");
+            print("[ModuleManager] Applied " + patchCount + " patches and found " + errorCount + " errors" );
             loaded = true;
 
         }
@@ -496,7 +530,14 @@ public void ApplyPatch(List<String> excludePaths, string Stage)
 
                             string[] splits = name.Split(sep, 3);
                             string pattern = splits.Length>1?splits[1]:null;
-                            string type = splits[0].Substring(1);                          
+                            string type = splits[0].Substring(1);
+
+                            if (!IsBraquetBalanced(mod.name))
+                            {
+                                print("[ModuleManager] Skipping a patch with unbalanced square brackets or a space (replace them with a '?') :\n" + mod.name + "\n");
+                                errorCount++;
+                                continue;
+                            }
 
                             foreach (UrlDir.UrlConfig url in GameDatabase.Instance.root.AllConfigs) {
                                 if (url.type == type