Skip to content

Commit 9b51aff

Browse files
committed
reverted lighthouse - browser is better
reverted lighthouse - browser is better
1 parent cd47cb9 commit 9b51aff

6 files changed

Lines changed: 2 additions & 885 deletions

File tree

.gitignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,3 @@ Thumbs.db
5151
# Cypress artefacts
5252
cypress/videos/**
5353
cypress/screenshots/**
54-
55-
# Lighthouse Report
56-
lhreport.html

README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,7 @@ ng-new-app your-app-name
118118
- pollyfills (for safari) '_web-animations-js_' added for animations support inside _@Component_ decorator
119119
- Local source analyzing tools `webpack-bundle-analyzer` and `source-map-explorer`, Local prod-build deploy and test with purgecss
120120
- [new✨] Pre-commit husky hook, run whatever command you want before git commit. By default prettifying changed/staged files and running lint is enabled, you can comment out run tests too. Refer .husky/pre-commit file for this operations. This helps you maintian same quality across team workspaces.
121-
- [new✨] Code-coverage report and its workflow (github action). Open index.html in generated coverage folder. Thanks to [@sapatgit](https://github.com/@sapatgit) for adding this and lighthouse report.
122-
- [new✨] Lighthouse report inspired from [Daniel Kreider's blog](https://medium.com/geekculture/this-simple-stunt-lets-me-release-a-speedy-angular-application-741d5803a44a).
121+
- [new✨] Test-coverage report and its workflow (github action). Check index.html in generated coverage folder. Thanks to [@sapatgit](https://github.com/@sapatgit) for adding this.
123122

124123
# There is a command for everything you need! 🧑🏻‍💻
125124

@@ -139,7 +138,6 @@ ng-new-app your-app-name
139138
| `npm run test:coverage` | Runs all the jests test cases and generate coverage report | [@briebug/jest-schematic](https://www.npmjs.com/package/@briebug/jest-schematic) |
140139
| `npm run e2e` | Opens up Cypress View to run your e2e tests in browser | [@briebug/cypress-schematic](https://www.npmjs.com/package/@briebug/cypress-schematic) |
141140
| `npm run e2e:ci` | Runs cypress tests in console (used for CI/CD) | [@briebug/cypress-schematic](https://www.npmjs.com/package/@briebug/cypress-schematic) |
142-
| `npm run lighthouse` | Opens lighthouse report | [lighthouse](https://www.npmjs.com/package/lighthouse) |
143141

144142
### Plan
145143

bin/generate-app.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ const features = [
3030
'Husky hooks preventing git commits unless all rules passed',
3131
'source-map-explorer and webpack-bundle-analyzer for prod build inspection of modules, you choose',
3232
'Local prod-build deploy and test on server',
33-
'Test coverage report',
34-
'Lighthouse performance, SEO, Accessibility report',
3533
'Github Actions Pipeline configured i.e prettify -> prettify:verify -> lint -> jest & cypress tests -> build -> purgecss -> deploy',
3634
'Prod build console warning, Bunch of custom commands, refer table in readme (https://github.com/sardapv/angular-material-starter-template#readme)',
3735
];
@@ -103,7 +101,6 @@ async function main() {
103101
console.log(` 3. Edit package.json and change starting details like author, description, git url, etc.`);
104102
console.log(` 4. If API calls supported, configure baseurl inenvironment*.ts files (don't end with /)`);
105103
console.log(' 5. Run npm start', '\x1b[0m');
106-
console.log(' 6. Add your new README.md', '\x1b[0m');
107104
console.log();
108105
console.log('step 4/4 ⏳');
109106
console.log();

lighthouse.js

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)