Skip to content

feat: modpacks#125

Open
Vilsol wants to merge 88 commits into
stagingfrom
feat/modpacks
Open

feat: modpacks#125
Vilsol wants to merge 88 commits into
stagingfrom
feat/modpacks

Conversation

@Vilsol

@Vilsol Vilsol commented Jun 24, 2025

Copy link
Copy Markdown
Member

Rob's list of assorted Rose To-Do's before this can be merged:

  • Make real name for 20260321003544 migration
  • Review all added code comments to ensure they are still relevant. If they suggest future work/changes, ideally turn them into github issues with links to that line in the code so we can discuss them later

@codecov

codecov Bot commented Jun 24, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 57.30337% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.56%. Comparing base (7b96fac) to head (bc7c1ac).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
dataloader/loaders.go 0.00% 14 Missing ⚠️
db/user.go 0.00% 11 Missing ⚠️
db/modpack.go 76.92% 5 Missing and 4 partials ⚠️
conversion/ent_to_graphql.go 82.60% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging     #125      +/-   ##
===========================================
+ Coverage    41.73%   43.56%   +1.83%     
===========================================
  Files          128      113      -15     
  Lines         6146     6613     +467     
===========================================
+ Hits          2565     2881     +316     
- Misses        3191     3274      +83     
- Partials       390      458      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vilsol Vilsol requested review from budak7273 and mircearoata June 24, 2025 23:41
@budak7273 budak7273 marked this pull request as draft April 4, 2026 03:13
rhit-mooretj and others added 22 commits April 27, 2026 18:31
…ts on release creation, added query for calculating lockfile & targets. tests may fail due to schema change
…tors to check their changes against the most recent staging dump
@budak7273 budak7273 marked this pull request as ready for review May 5, 2026 22:54

@budak7273 budak7273 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review all added code comments (that aren't generated) to ensure they are still relevant. If they suggest future work/changes, ideally turn them into github issues with links to that line in the code so we can discuss them later

Comment thread migrations/sql/20260321003544_modpack_deletion.up.sql
@budak7273 budak7273 moved this to 👀 Ready for Ficsit Team review in Rose Senior Project May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: 👀 Ready for Ficsit Team review

Development

Successfully merging this pull request may close these issues.

5 participants