Skip to content

Commit 6adc8b8

Browse files
committed
refactor(ui): avoid newlines in tr() strings
* Move newline characters out of translatable text passed to `tr()` to avoid translators accidentally altering formatting and to ensure correct argument substitution. * Standardize string concatenation for the summary report and invalid key database details in the UI to improve translation safety and readability. * Purely formatting/refactor changes; no functional behavior altered.
1 parent 01b38d9 commit 6adc8b8

2 files changed

Lines changed: 10 additions & 9 deletions

File tree

src/ui/main_window/MainWindow.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -314,8 +314,8 @@ auto MainWindow::check_and_notify_invalid_key_dbs() -> void {
314314
for (const auto& key_db : key_dbs) {
315315
if (!key_db.valid) {
316316
invalid_count++;
317-
details +=
318-
tr("Name: %1\nPath: %2\n\n").arg(key_db.name, key_db.origin_path);
317+
details += tr("Name: %1").arg(key_db.name) + "\n" +
318+
tr("Path: %1").arg(key_db.origin_path) + "\n\n";
319319
}
320320
}
321321

src/ui/main_window/MainWindowSlotFunction.cpp

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -340,19 +340,20 @@ void MainWindow::slot_result_analyse_show_helper(
340340

341341
// Prepare summary section
342342
summary.append("# " + tr("Summary Report") + "\n\n");
343-
summary.append("- " + tr("Total Operations: %1\n").arg(opera_results.size()));
344-
summary.append("- " + tr("Successful: %1\n").arg(success_count));
345-
summary.append("- " + tr("Warnings: %1\n").arg(warn_count));
346-
summary.append("- " + tr("Failures: %1\n").arg(fail_count));
343+
summary.append("- " + tr("Total Operations: %1").arg(opera_results.size()) +
344+
"\n");
345+
summary.append("- " + tr("Successful: %1").arg(success_count) + "\n");
346+
summary.append("- " + tr("Warnings: %1").arg(warn_count) + "\n");
347+
summary.append("- " + tr("Failures: %1").arg(fail_count) + "\n");
347348

348349
if (!failed_tags.isEmpty()) {
349350
summary.append("- " +
350-
tr("Failed Objects: %1\n").arg(failed_tags.join(", ")));
351+
tr("Failed Objects: %1").arg(failed_tags.join(", ") + "\n"));
351352
}
352353

353354
if (!warning_tags.isEmpty()) {
354-
summary.append("- " +
355-
tr("Warning Objects: %1\n").arg(warning_tags.join(", ")));
355+
summary.append(
356+
"- " + tr("Warning Objects: %1").arg(warning_tags.join(", ") + "\n"));
356357
}
357358

358359
// Display the final report in the info board

0 commit comments

Comments
 (0)