refactor(ui): standardize widget method naming

saturneric · saturneric · commit 75ddc9c19984 · 2026-04-27T17:20:21.000+02:00
* Renames several UI helper/slot methods to a consistent lowercase style
  for improved readability and convention alignment
* Updates signal/slot hookups and call sites to match the new names
* Keeps behavior unchanged while reducing naming inconsistencies across
  common widgets
diff --git a/src/ui/widgets/FilePage.cpp b/src/ui/widgets/FilePage.cpp
@@ -135,7 +135,7 @@ FilePage::FilePage(QWidget* parent, const QString& target_path)
     : QWidget(parent),
       ui_(GpgFrontend::SecureCreateSharedObject<Ui_FilePage>()) {
   ui_->setupUi(this);
-  InitUIStyle();
+  init_ui_style();
 
   connect(ui_->upPathButton, &QToolButton::clicked, ui_->treeView,
           &FileTreeView::SlotUpLevel);
@@ -161,7 +161,7 @@ FilePage::FilePage(QWidget* parent, const QString& target_path)
           &FilePage::SlotGoPath);
 
   connect(ui_->pathEdit, &QLineEdit::textEdited, this,
-          [this](const QString& text) { UpdatePathCompletion(text); });
+          [this](const QString& text) { update_path_completion(text); });
 
   connect(path_edit_completer_,
           QOverload<const QString&>::of(&QCompleter::activated), this,
@@ -255,7 +255,7 @@ FilePage::FilePage(QWidget* parent, const QString& target_path)
   QTimer::singleShot(200, this, &FilePage::update_harddisk_menu_periodic);
 }
 
-void FilePage::InitUIStyle() {
+void FilePage::init_ui_style() {
   setObjectName(QStringLiteral("FilePage"));
 
   ui_->pathEdit->setClearButtonEnabled(true);
@@ -388,7 +388,7 @@ auto FilePage::IsBatchMode() const -> bool {
 
 auto FilePage::IsASCIIMode() const -> bool { return ascii_mode_; }
 
-void FilePage::UpdatePathCompletion(const QString& input) {
+void FilePage::update_path_completion(const QString& input) {
   if (input.trimmed().isEmpty()) {
     path_complete_model_->setStringList({});
     return;
diff --git a/src/ui/widgets/FilePage.h b/src/ui/widgets/FilePage.h
@@ -48,12 +48,6 @@ class FilePage : public QWidget {
    */
   explicit FilePage(QWidget* parent, const QString&);
 
-  /**
-   * @brief
-   *
-   */
-  void InitUIStyle();
-
   /**
    * @brief Get the Selected object
    *
@@ -77,13 +71,6 @@ class FilePage : public QWidget {
    */
   [[nodiscard]] auto IsASCIIMode() const -> bool;
 
-  /**
-   * @brief
-   *
-   * @param input
-   */
-  void UpdatePathCompletion(const QString& input);
-
   /**
    * @brief Get the Current Path object
    *
@@ -147,8 +134,6 @@ class FilePage : public QWidget {
 
   QSet<QString> last_volume_keys_;  ///<
 
- private slots:
-
   /**
    * @brief
    *
@@ -166,6 +151,19 @@ class FilePage : public QWidget {
    *
    */
   void update_harddisk_menu_periodic();
+
+  /**
+   * @brief
+   *
+   */
+  void init_ui_style();
+
+  /**
+   * @brief
+   *
+   * @param input
+   */
+  void update_path_completion(const QString& input);
 };
 
 }  // namespace GpgFrontend::UI
diff --git a/src/ui/widgets/FileTreeView.cpp b/src/ui/widgets/FileTreeView.cpp
@@ -334,7 +334,7 @@ void FileTreeView::SlotMkdir() {
 }
 
 void FileTreeView::SlotMkdirBelowAtSelectedItem() {
-  const auto target_dir = CurrentTargetDirectoryPath();
+  const auto target_dir = current_target_directory_path();
   if (target_dir.isEmpty()) return;
 
   CreateFileSystemItemDialog dialog(
@@ -374,7 +374,7 @@ void FileTreeView::SlotTouch() {
 }
 
 void FileTreeView::SlotTouchBelowAtSelectedItem() {
-  const auto target_dir = CurrentTargetDirectoryPath();
+  const auto target_dir = current_target_directory_path();
   if (target_dir.isEmpty()) return;
 
   CreateFileSystemItemDialog dialog(CreateFileSystemItemDialog::ItemType::kFILE,
@@ -783,7 +783,7 @@ void FileTreeView::SetPath(const QString& target_path) {
   }
 }
 
-auto FileTreeView::CurrentTargetDirectoryIndex() const -> QModelIndex {
+auto FileTreeView::current_target_directory_index() const -> QModelIndex {
   auto index = currentIndex();
 
   if (!index.isValid()) {
@@ -798,7 +798,7 @@ auto FileTreeView::CurrentTargetDirectoryIndex() const -> QModelIndex {
   return index.parent().isValid() ? index.parent() : rootIndex();
 }
 
-auto FileTreeView::CurrentTargetDirectoryPath() const -> QString {
+auto FileTreeView::current_target_directory_path() const -> QString {
   auto index = currentIndex();
 
   if (!index.isValid()) {
diff --git a/src/ui/widgets/FileTreeView.h b/src/ui/widgets/FileTreeView.h
@@ -77,20 +77,6 @@ class FileTreeView : public QTreeView {
    */
   auto GetMousePointGlobal(const QPoint& point) -> QPoint;
 
-  /**
-   * @brief
-   *
-   * @return QModelIndex
-   */
-  [[nodiscard]] auto CurrentTargetDirectoryIndex() const -> QModelIndex;
-
-  /**
-   * @brief
-   *
-   * @return QString
-   */
-  [[nodiscard]] auto CurrentTargetDirectoryPath() const -> QString;
-
  protected:
   /**
    * @brief
@@ -373,5 +359,19 @@ class FileTreeView : public QTreeView {
    */
   auto copy_directory_recursive(const QString& source_dir,
                                 const QString& target_dir) -> bool;
+
+  /**
+   * @brief
+   *
+   * @return QModelIndex
+   */
+  [[nodiscard]] auto current_target_directory_index() const -> QModelIndex;
+
+  /**
+   * @brief
+   *
+   * @return QString
+   */
+  [[nodiscard]] auto current_target_directory_path() const -> QString;
 };
 }  // namespace GpgFrontend::UI
diff --git a/src/ui/widgets/KeyList.cpp b/src/ui/widgets/KeyList.cpp
@@ -95,7 +95,7 @@ KeyList::KeyList(int channel, KeyMenuAbility menu_ability,
   init();
 }
 
-auto KeyList::HasAbility(KeyMenuAbility ability) const -> bool {
+auto KeyList::has_ability(KeyMenuAbility ability) const -> bool {
   using T = std::underlying_type_t<KeyMenuAbility>;
 
   return (static_cast<T>(menu_ability_) & static_cast<T>(ability)) !=
@@ -105,15 +105,15 @@ auto KeyList::HasAbility(KeyMenuAbility ability) const -> bool {
 void KeyList::init_ui_visibility() {
   ui_->menuWidget->setHidden(menu_ability_ == KeyMenuAbility::kNONE);
 
-  ui_->refreshKeyListButton->setHidden(!HasAbility(KeyMenuAbility::kREFRESH));
-  ui_->syncButton->setHidden(!HasAbility(KeyMenuAbility::kSYNC_PUBLIC_KEY));
-  ui_->checkALLButton->setHidden(!HasAbility(KeyMenuAbility::kCHECK_ALL));
-  ui_->uncheckButton->setHidden(!HasAbility(KeyMenuAbility::kUNCHECK_ALL));
-  ui_->columnTypeButton->setHidden(!HasAbility(KeyMenuAbility::kCOLUMN_FILTER));
-  ui_->searchBarEdit->setHidden(!HasAbility(KeyMenuAbility::kSEARCH_BAR));
+  ui_->refreshKeyListButton->setHidden(!has_ability(KeyMenuAbility::kREFRESH));
+  ui_->syncButton->setHidden(!has_ability(KeyMenuAbility::kSYNC_PUBLIC_KEY));
+  ui_->checkALLButton->setHidden(!has_ability(KeyMenuAbility::kCHECK_ALL));
+  ui_->uncheckButton->setHidden(!has_ability(KeyMenuAbility::kUNCHECK_ALL));
+  ui_->columnTypeButton->setHidden(!has_ability(KeyMenuAbility::kCOLUMN_FILTER));
+  ui_->searchBarEdit->setHidden(!has_ability(KeyMenuAbility::kSEARCH_BAR));
   ui_->switchContextButton->setHidden(
-      !HasAbility(KeyMenuAbility::kKEY_DATABASE));
-  ui_->keyGroupButton->setHidden(!HasAbility(KeyMenuAbility::kKEY_GROUP));
+      !has_ability(KeyMenuAbility::kKEY_DATABASE));
+  ui_->keyGroupButton->setHidden(!has_ability(KeyMenuAbility::kKEY_GROUP));
 }
 
 void KeyList::init_ui_style() {
diff --git a/src/ui/widgets/KeyList.h b/src/ui/widgets/KeyList.h
@@ -235,15 +235,6 @@ class KeyList : public QWidget {
    */
   void RefreshKeyTable(int index);
 
-  /**
-   * @brief
-   *
-   * @param ability
-   * @return true
-   * @return false
-   */
-  [[nodiscard]] auto HasAbility(KeyMenuAbility ability) const -> bool;
-
  public slots:
 
   /**
@@ -427,6 +418,15 @@ class KeyList : public QWidget {
    *
    */
   void update_action_state();
+
+  /**
+   * @brief
+   *
+   * @param ability
+   * @return true
+   * @return false
+   */
+  [[nodiscard]] auto has_ability(KeyMenuAbility ability) const -> bool;
 };
 
 }  // namespace GpgFrontend::UI
diff --git a/src/ui/widgets/KeyTable.cpp b/src/ui/widgets/KeyTable.cpp
@@ -56,7 +56,7 @@ KeyTable::KeyTable(QWidget* parent, QSharedPointer<GpgKeyTableModel> model,
       proxy_model_(model_, select_type, column_filter, std::move(filter), this),
       column_filter_(column_filter) {
   setModel(&proxy_model_);
-  InitTableStyle();
+  init_table_style();
 
   connect(CommonUtils::GetInstance(), &CommonUtils::SignalFavoritesChanged,
           &proxy_model_, &GpgKeyTableProxyModel::SignalFavoritesChanged);
@@ -87,7 +87,7 @@ KeyTable::KeyTable(QWidget* parent, QSharedPointer<GpgKeyTableModel> model,
           });
 }
 
-void KeyTable::InitTableStyle() {
+void KeyTable::init_table_style() {
   setProperty("gfKeyTable", true);
 
   verticalHeader()->hide();
diff --git a/src/ui/widgets/KeyTable.h b/src/ui/widgets/KeyTable.h
@@ -57,12 +57,6 @@ struct KeyTable : public QTableView {
       GpgKeyTableProxyModel::KeyFilter _filter =
           [](const GpgAbstractKey*) -> bool { return true; });
 
-  /**
-   * @brief Construct a new Init Table Style object
-   *
-   */
-  void InitTableStyle();
-
   /**
    * @brief
    *
@@ -179,6 +173,12 @@ struct KeyTable : public QTableView {
   GpgKeyTableProxyModel proxy_model_;
   GpgKeyTableColumn column_filter_;
   bool bulk_checking_ = false;
+
+  /**
+   * @brief Construct a new Init Table Style object
+   *
+   */
+  void init_table_style();
 };
 
 }  // namespace GpgFrontend::UI
diff --git a/src/ui/widgets/KeyTreeView.cpp b/src/ui/widgets/KeyTreeView.cpp
@@ -61,7 +61,7 @@ KeyTreeView::KeyTreeView(int channel,
   init();
 }
 
-void KeyTreeView::InitViewStyle() {
+void KeyTreeView::init_view_style() {
   setProperty("gfKeyTreeView", true);
 
   setRootIsDecorated(true);
@@ -148,7 +148,7 @@ auto KeyTreeView::GetAllCheckedSubKey() -> QContainer<GpgSubKey> {
 void KeyTreeView::init() {
   setModel(&proxy_model_);
 
-  InitViewStyle();
+  init_view_style();
 
   connect(this, &QTreeView::doubleClicked, this,
           [this](const QModelIndex& index) {
@@ -163,15 +163,15 @@ void KeyTreeView::init() {
 
   connect(UISignalStation::GetInstance(),
           &UISignalStation::SignalKeyDatabaseRefreshDone, this,
-          &KeyTreeView::ResetModel);
+          &KeyTreeView::reset_model);
 
   connect(model_.get(), &GpgKeyTreeModel::SignalKeyCheckedChanged, this,
           [this](GpgAbstractKey*, bool) {
             emit SignalKeysChecked(GetAllCheckedKeys());
           });
 }
 
-void KeyTreeView::ResetModel() {
+void KeyTreeView::reset_model() {
   init_ = false;
 
   model_ = SecureCreateSharedObject<GpgKeyTreeModel>(
@@ -203,7 +203,7 @@ void KeyTreeView::SetChannel(int channel) {
   LOG_D() << "new channel for key tree view: " << channel;
 
   channel_ = channel;
-  ResetModel();
+  reset_model();
 }
 
 auto KeyTreeView::GetKeyByIndex(QModelIndex index) -> GpgAbstractKeyPtr {
@@ -221,7 +221,7 @@ auto KeyTreeView::GetKeyByIndex(QModelIndex index) -> GpgAbstractKeyPtr {
   return item->SharedKey();
 }
 
-void KeyTreeView::Refresh() { ResetModel(); }
+void KeyTreeView::Refresh() { reset_model(); }
 
 auto KeyTreeView::GetAllCheckedKeys() -> GpgAbstractKeyPtrList {
   return model_->GetAllCheckedKeys();
diff --git a/src/ui/widgets/KeyTreeView.h b/src/ui/widgets/KeyTreeView.h
@@ -63,18 +63,6 @@ class KeyTreeView : public QTreeView {
                        GpgKeyTreeProxyModel::KeyFilter filter,
                        QWidget* parent = nullptr);
 
-  /**
-   * @brief
-   *
-   */
-  void InitViewStyle();
-
-  /**
-   * @brief
-   *
-   */
-  void ResetModel();
-
   /**
    * @brief Get the Key By Index object
    *
@@ -142,20 +130,37 @@ class KeyTreeView : public QTreeView {
  private:
   bool init_ = false;
   int channel_ = kGpgFrontendDefaultChannel;
-
   GpgKeyTreeModel::Detector checkable_detector_ = [](GpgAbstractKey*) -> bool {
     return false;
   };
-
   GpgKeyTreeProxyModel::KeyFilter key_filter_ =
       [](const GpgAbstractKey*) -> bool { return true; };
-
   QSharedPointer<GpgKeyTreeModel> model_;
   GpgKeyTreeProxyModel proxy_model_;
 
+  /**
+   * @brief
+   *
+   */
   void slot_adjust_column_widths();
 
+  /**
+   * @brief
+   *
+   */
   void init();
+
+  /**
+   * @brief
+   *
+   */
+  void init_view_style();
+
+  /**
+   * @brief
+   *
+   */
+  void reset_model();
 };
 
 }  // namespace GpgFrontend::UI

Original file line number	Diff line number	Diff line change
`@@ -334,7 +334,7 @@ void FileTreeView::SlotMkdir() {`
`334`	`334`	`}`
`335`	`335`
`336`	`336`	`void FileTreeView::SlotMkdirBelowAtSelectedItem() {`
`337`		`- const auto target_dir = CurrentTargetDirectoryPath();`
	`337`	`+ const auto target_dir = current_target_directory_path();`
`338`	`338`	`if (target_dir.isEmpty()) return;`
`339`	`339`
`340`	`340`	`CreateFileSystemItemDialog dialog(`
`@@ -374,7 +374,7 @@ void FileTreeView::SlotTouch() {`
`374`	`374`	`}`
`375`	`375`
`376`	`376`	`void FileTreeView::SlotTouchBelowAtSelectedItem() {`
`377`		`- const auto target_dir = CurrentTargetDirectoryPath();`
	`377`	`+ const auto target_dir = current_target_directory_path();`
`378`	`378`	`if (target_dir.isEmpty()) return;`
`379`	`379`
`380`	`380`	`CreateFileSystemItemDialog dialog(CreateFileSystemItemDialog::ItemType::kFILE,`
`@@ -783,7 +783,7 @@ void FileTreeView::SetPath(const QString& target_path) {`
`783`	`783`	`}`
`784`	`784`	`}`
`785`	`785`
`786`		`-auto FileTreeView::CurrentTargetDirectoryIndex() const -> QModelIndex {`
	`786`	`+auto FileTreeView::current_target_directory_index() const -> QModelIndex {`
`787`	`787`	`auto index = currentIndex();`
`788`	`788`
`789`	`789`	`if (!index.isValid()) {`
`@@ -798,7 +798,7 @@ auto FileTreeView::CurrentTargetDirectoryIndex() const -> QModelIndex {`
`798`	`798`	`return index.parent().isValid() ? index.parent() : rootIndex();`
`799`	`799`	`}`
`800`	`800`
`801`		`-auto FileTreeView::CurrentTargetDirectoryPath() const -> QString {`
	`801`	`+auto FileTreeView::current_target_directory_path() const -> QString {`
`802`	`802`	`auto index = currentIndex();`
`803`	`803`
`804`	`804`	`if (!index.isValid()) {`