feat(ui): add type-aware algo selection helpers

* Adds type-aware algorithm lookup helpers to avoid ambiguous matches when
  multiple algorithms share a name
* Introduces a combo box population utility that sorts entries, keeps `none`
  first, and de-duplicates labels for a cleaner selection UI
* Provides id+type lookup with id-only fallback when type is empty to preserve
  backward compatibility

Co-authored-by: Copilot <copilot@github.com>

Author: saturneric

src/ui/function/KeyGenerateHelper.cpp

@@ -40,34 +40,40 @@ auto GetAlgoById(const QString& id, const QContainer<KeyAlgo>& algos)
   return {};
 }
 
-auto SearchAlgoByName(const QString& name, const QContainer<KeyAlgo>& algos)
+auto SearchAlgoByNameType(const QString& name, const QString& type,
+                          const QContainer<KeyAlgo>& algos)
     -> QContainer<KeyAlgo> {
   QContainer<KeyAlgo> res;
 
   for (const auto& algo : algos) {
     if (algo.Name() != name) continue;
+    if (algo.Type() != type) continue;
     res.append(algo);
   }
 
   return res;
 }
 
-auto GetAlgoByNameAndKeyLength(const QString& name, int key_length,
-                               const QContainer<KeyAlgo>& algos)
+auto GetAlgoByNameTypeAndKeyLength(const QString& name, const QString& type,
+                                   int key_length,
+                                   const QContainer<KeyAlgo>& algos)
     -> std::tuple<bool, KeyAlgo> {
   for (const auto& algo : algos) {
     if (algo.Name() != name) continue;
+    if (algo.Type() != type) continue;
     if (algo.KeyLength() != key_length) continue;
     return {true, algo};
   }
 
   return {};
 }
 
-auto GetAlgoByName(const QString& name, const QContainer<KeyAlgo>& algos)
+auto GetAlgoByNameType(const QString& name, const QString& type,
+                       const QContainer<KeyAlgo>& algos)
     -> std::tuple<bool, KeyAlgo> {
   for (const auto& algo : algos) {
     if (algo.Name() != name) continue;
+    if (algo.Type() != type) continue;
     return {true, algo};
   }
 
@@ -91,4 +97,63 @@ void SetKeyLengthComboxBoxByAlgo(QComboBox* combo,
 
   combo->addItems(key_lengths);
 }
+
+void PopulateAlgoComboBox(QComboBox* combo_box,
+                          const QContainer<KeyAlgo>& algos) {
+  if (combo_box == nullptr) return;
+
+  auto sorted_algos = algos;
+
+  std::sort(sorted_algos.begin(), sorted_algos.end(),
+            [](const KeyAlgo& a, const KeyAlgo& b) -> bool {
+              if (a.Id() == "none" && b.Id() != "none") return true;
+              if (b.Id() == "none" && a.Id() != "none") return false;
+
+              if (a.Name() != b.Name()) return a.Name() < b.Name();
+              if (a.Type() != b.Type()) return a.Type() < b.Type();
+              if (a.KeyLength() != b.KeyLength()) {
+                return a.KeyLength() < b.KeyLength();
+              }
+              return a.Id() < b.Id();
+            });
+
+  combo_box->clear();
+
+  QString last_label;
+  QString last_type;
+
+  for (const auto& algo : sorted_algos) {
+    QString label;
+
+    if (algo.Id() == "none") {
+      label = algo.Name();
+    } else {
+      label = QString("%1 (%2)").arg(algo.Name(), algo.Type());
+    }
+
+    if (label == last_label && algo.Type() == last_type) continue;
+    last_label = label;
+    last_type = algo.Type();
+
+    QVariantMap data;
+    data["id"] = algo.Id();
+    data["name"] = algo.Name();
+    data["type"] = algo.Type();
+
+    combo_box->addItem(label, data);
+  }
+}
+
+auto GetAlgoByIdType(const QString& id, const QString& type,
+                     const QContainer<KeyAlgo>& algos)
+    -> std::tuple<bool, KeyAlgo> {
+  for (const auto& algo : algos) {
+    if (algo.Id() != id) continue;
+    if (!type.isEmpty() && algo.Type() != type) continue;
+    return {true, algo};
+  }
+
+  return {};
+}
+
 }  // namespace GpgFrontend::UI

src/ui/function/KeyGenerateHelper.h

@@ -43,13 +43,15 @@ auto GetAlgoById(const QString& id, const QContainer<KeyAlgo>& algos)
     -> std::tuple<bool, KeyAlgo>;
 
 /**
- * @brief
+ * @brief Search for algorithms by name and type
  *
  * @param name
+ * @param type
  * @param algos
  * @return QContainer<KeyAlgo>
  */
-auto SearchAlgoByName(const QString& name, const QContainer<KeyAlgo>& algos)
+auto SearchAlgoByNameType(const QString& name, const QString& type,
+                          const QContainer<KeyAlgo>& algos)
     -> QContainer<KeyAlgo>;
 
 /**
@@ -60,8 +62,9 @@ auto SearchAlgoByName(const QString& name, const QContainer<KeyAlgo>& algos)
  * @param algos
  * @return std::tuple<bool, KeyAlgo>
  */
-auto GetAlgoByNameAndKeyLength(const QString& name, int key_length,
-                               const QContainer<KeyAlgo>& algos)
+auto GetAlgoByNameTypeAndKeyLength(const QString& name, const QString& type,
+                                   int key_length,
+                                   const QContainer<KeyAlgo>& algos)
     -> std::tuple<bool, KeyAlgo>;
 
 /**
@@ -71,7 +74,8 @@ auto GetAlgoByNameAndKeyLength(const QString& name, int key_length,
  * @param algos
  * @return std::tuple<bool, KeyAlgo>
  */
-auto GetAlgoByName(const QString& name, const QContainer<KeyAlgo>& algos)
+auto GetAlgoByNameType(const QString& name, const QString& type,
+                       const QContainer<KeyAlgo>& algos)
     -> std::tuple<bool, KeyAlgo>;
 
 /**
@@ -82,4 +86,29 @@ auto GetAlgoByName(const QString& name, const QContainer<KeyAlgo>& algos)
  */
 void SetKeyLengthComboxBoxByAlgo(QComboBox* combo,
                                  const QContainer<KeyAlgo>& algos);
+
+/**
+ * @brief
+ *
+ * @param combo_box
+ * @param algos
+ */
+void PopulateAlgoComboBox(QComboBox* combo_box,
+                          const QContainer<KeyAlgo>& algos);
+
+/**
+ * @brief Get the Algo By Id And Type object
+ *
+ * If type is empty, this function falls back to id-only matching for backward
+ * compatibility.
+ *
+ * @param id
+ * @param type
+ * @param algos
+ * @return std::tuple<bool, KeyAlgo>
+ */
+auto GetAlgoByIdType(const QString& id, const QString& type,
+                     const QContainer<KeyAlgo>& algos)
+    -> std::tuple<bool, KeyAlgo>;
+
 }  // namespace GpgFrontend::UI