This repository was archived by the owner on Nov 27, 2022. It is now read-only.
feat: add animationEnabled to TabView#1388
Merged
okwasniewski merged 8 commits intoSep 30, 2022
Merged
Conversation
okwasniewski
suggested changes
Sep 5, 2022
satya164
suggested changes
Sep 5, 2022
Contributor
Author
|
@satya164 I updated my code as you said, could you please look at it again? |
szymonrybczak
changed the title
okwasniewski
reviewed
Sep 9, 2022
satya164
suggested changes
Sep 9, 2022
satya164
left a comment
satya164
left a comment
Owner
There was a problem hiding this comment.
This also needs to be handled in PanResponderAdapter for Web, where it should call panX.setValue instead of performing an animation
szymonrybczak
force-pushed
the
feat/add-disable-animation
branch
from
2f568d8 to
13c2037
Compare
okwasniewski
approved these changes
Sep 10, 2022
satya164
suggested changes
Sep 19, 2022
szymonrybczak
force-pushed
the
feat/add-disable-animation
branch
from
939cc0a to
07ee1b0
Compare
Contributor
|
Hi, I have made a separated PR: see #1391 because I need to be able to deactivate animation only for distant tabs (I need to keep them for neighbor tabs) |
satya164
approved these changes
Sep 30, 2022
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
According to this issue #1371 I added the
disableChangeTabAnimationto disable animation when changing tab.