Changed using of VulnerabilityDto to VulnerabilityMetadataDto (#2820)

### What's done:
- changed using of `VulnerabilityDto` to `VulnerabilityMetadataDto`.
- deleted class `VulnerabilityDto`.

Closes #2819

Author: DrAlexD

save-backend/src/main/kotlin/com/saveourtool/save/backend/controllers/vulnerability/VulnerabilityController.kt

@@ -103,7 +103,7 @@ class VulnerabilityController(
     @ApiResponse(responseCode = "200", description = "Successfully fetched vulnerability by identifier")
     fun getVulnerabilityByIdentifierAndActive(
         @RequestParam identifier: String,
-    ): Mono<VulnerabilityDto> = blockingToMono { vulnerabilityService.findByName(identifier) }
+    ): Mono<VulnerabilityMetadataDto> = blockingToMono { vulnerabilityService.findByName(identifier) }
         .switchIfEmptyToNotFound()
 
     @GetMapping("/by-identifier-with-description")

save-backend/src/main/kotlin/com/saveourtool/save/backend/security/VulnerabilityPermissionEvaluator.kt

@@ -3,7 +3,7 @@ package com.saveourtool.save.backend.security
 import com.saveourtool.save.backend.service.vulnerability.VulnerabilityService
 import com.saveourtool.save.backend.utils.hasRole
 import com.saveourtool.save.domain.Role
-import com.saveourtool.save.entities.vulnerability.VulnerabilityDto
+import com.saveourtool.save.entities.cosv.VulnerabilityMetadataDto
 import com.saveourtool.save.entities.vulnerability.VulnerabilityStatus
 
 import com.saveourtool.save.permission.Permission
@@ -49,8 +49,8 @@ class VulnerabilityPermissionEvaluator(
      * @param authentication
      * @return check permission
      */
-    fun hasFullPermission(vulnerability: VulnerabilityDto, authentication: Authentication): Boolean {
+    fun hasFullPermission(vulnerability: VulnerabilityMetadataDto, authentication: Authentication): Boolean {
         val linkUsers = vulnerabilityService.getUsers(vulnerability.identifier).map { it.name }
-        return vulnerability.userInfo.name == authentication.name || authentication.name in linkUsers
+        return vulnerability.user.name == authentication.name || authentication.name in linkUsers
     }
 }

save-backend/src/main/kotlin/com/saveourtool/save/backend/service/vulnerability/VulnerabilityService.kt

@@ -57,7 +57,7 @@ class VulnerabilityService(
      * @param name name of vulnerability
      * @return vulnerability by name
      */
-    fun findByName(name: String) = vulnerabilityMetadataRepository.findByIdentifier(name)?.toDto()?.toVulnerabilityDto()
+    fun findByName(name: String) = vulnerabilityMetadataRepository.findByIdentifier(name)?.toDto()
 
     /**
      * @param userName
@@ -293,7 +293,7 @@ class VulnerabilityService(
 
     /**
      * @param vulnerabilityProjectDtos dto list of vulnerability projects
-     * @return [VulnerabilityDto] with saved [vulnerabilityProjectDtos]
+     * @return list of [VulnerabilityProjectDto]
      */
     @Transactional
     fun saveAllProjects(

save-cloud-common/src/commonMain/kotlin/com/saveourtool/save/entities/cosv/VulnerabilityExt.kt

@@ -1,7 +1,6 @@
 package com.saveourtool.save.entities.cosv
 
 import com.saveourtool.save.info.UserInfo
-import com.saveourtool.save.utils.getRelatedLink
 
 import com.saveourtool.osv4k.RawOsvSchema as RawCosvSchema
 
@@ -18,14 +17,6 @@ data class VulnerabilityExt(
     val cosv: RawCosvSchema,
     val saveContributors: List<UserInfo>,
 ) {
-    /**
-     * @return a vulnerability dto with description
-     */
-    fun toVulnerabilityDtoWithDescription() = metadataDto.toVulnerabilityDto().copy(
-        description = metadataDto.details,
-        relatedLink = cosv.getRelatedLink(),
-    )
-
     /**
      * @return contributors + owner (creator)
      */

save-cloud-common/src/commonMain/kotlin/com/saveourtool/save/entities/cosv/VulnerabilityMetadataDto.kt

@@ -1,7 +1,6 @@
 package com.saveourtool.save.entities.cosv
 
 import com.saveourtool.save.entities.OrganizationDto
-import com.saveourtool.save.entities.vulnerability.VulnerabilityDto
 import com.saveourtool.save.entities.vulnerability.VulnerabilityLanguage
 import com.saveourtool.save.entities.vulnerability.VulnerabilityStatus
 import com.saveourtool.save.info.UserInfo
@@ -35,26 +34,6 @@ data class VulnerabilityMetadataDto(
     val status: VulnerabilityStatus,
     val tags: Set<String> = emptySet(),
 ) {
-    /**
-     * @return a vulnerability dto
-     */
-    fun toVulnerabilityDto() = VulnerabilityDto(
-        identifier = identifier,
-        progress = severityNum,
-        projects = emptyList(),  // TODO: not supported yet
-        description = null,  // it's empty by old logic
-        shortDescription = summary,
-        relatedLink = null,  // FIXME: related link is not available here
-        language = language,
-        userInfo = user,  // it was empty in old logic, but will populate to simplify the logic
-        organization = organization,
-        dates = emptyList(),
-        participants = emptyList(),
-        status = status,
-        creationDateTime = submitted,
-        lastUpdatedDateTime = modified,
-    )
-
     companion object {
         /**
          * The maximum length of [summary] (and of `VulnerabilityMetadata.summary`).

save-cloud-common/src/commonMain/kotlin/com/saveourtool/save/entities/vulnerability/VulnerabilityDto.kt

@@ -5,7 +5,6 @@
 package com.saveourtool.save.utils
 
 import com.saveourtool.save.entities.vulnerability.*
-import com.saveourtool.save.entities.vulnerability.VulnerabilityDto.Companion.vulnerabilityPrefixes
 import com.saveourtool.save.info.UserInfo
 
 import com.saveourtool.osv4k.*

save-cloud-common/src/commonMain/kotlin/com/saveourtool/save/utils/CosvSchemaUtils.kt

@@ -5,7 +5,6 @@
 package com.saveourtool.save.frontend.components.basic.organizations
 
 import com.saveourtool.save.entities.cosv.VulnerabilityMetadataDto
-import com.saveourtool.save.entities.vulnerability.VulnerabilityDto
 import com.saveourtool.save.filters.VulnerabilityFilter
 import com.saveourtool.save.frontend.components.tables.TableProps
 import com.saveourtool.save.frontend.components.tables.columns
@@ -31,7 +30,7 @@ private val vulnerabilitiesUrl = "$apiUrl/vulnerabilities"
 private val vulnerabilityTable: FC<VulnerabilityTableProps> = tableComponent(
     columns = {
         columns {
-            column(id = "name", header = "Name", VulnerabilityDto::identifier) { cellContext ->
+            column(id = "name", header = "Name", VulnerabilityMetadataDto::identifier) { cellContext ->
                 Fragment.create {
                     td {
                         Link {
@@ -42,21 +41,21 @@ private val vulnerabilityTable: FC<VulnerabilityTableProps> = tableComponent(
                     }
                 }
             }
-            column(id = "short_description", header = "Description", VulnerabilityDto::shortDescription) { cellContext ->
+            column(id = "short_description", header = "Description", VulnerabilityMetadataDto::summary) { cellContext ->
                 Fragment.create {
                     td {
                         +cellContext.value
                     }
                 }
             }
-            column(id = "progress", header = "Criticality", VulnerabilityDto::progress) { cellContext ->
+            column(id = "progress", header = "Criticality", VulnerabilityMetadataDto::severityNum) { cellContext ->
                 Fragment.create {
                     td {
                         +cellContext.value.toString()
                     }
                 }
             }
-            column(id = "language", header = "Language", VulnerabilityDto::language) { cellContext ->
+            column(id = "language", header = "Language", VulnerabilityMetadataDto::language) { cellContext ->
                 Fragment.create {
                     td {
                         +cellContext.value.toString()
@@ -115,12 +114,9 @@ val organizationVulnerabilitiesTab: FC<OrganizationVulnerabilitiesMenuProps> = F
                         body = filterJson,
                         loadingHandler = ::loadingHandler,
                         responseHandler = ::noopResponseHandler,
-                    )
-                        .unsafeMap<Array<out VulnerabilityMetadataDto>> { response ->
-                            response.decodeFromJsonString()
-                        }
-                        .map(VulnerabilityMetadataDto::toVulnerabilityDto)
-                        .toTypedArray()
+                    ).unsafeMap { response ->
+                        response.decodeFromJsonString()
+                    }
                 }
                 getPageCount = { pageSize ->
                     pageCount(count, pageSize)
@@ -147,7 +143,7 @@ val organizationVulnerabilitiesTab: FC<OrganizationVulnerabilitiesMenuProps> = F
  *
  * @see vulnerabilityTable
  */
-external interface VulnerabilityTableProps : TableProps<VulnerabilityDto> {
+external interface VulnerabilityTableProps : TableProps<VulnerabilityMetadataDto> {
     /**
      * The total count of approved vulnerabilities for this organization.
      */