idstack/test/test-version-classifier.sh at b3407e4fbcdcf1cb287fe610e1a0b0b14d7b53e8 · savvides/idstack · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
#!/usr/bin/env bash
# Unit tests for the legacy-VERSION classifier shared by setup and
# bin/idstack-doctor. Both files use the same two-arm case statement to
# decide whether a VERSION file under the legacy install path means
# "modern install — leave alone" (skip) or "pre-v2.0.1.0 install — flag
# for cleanup" (legacy).
#
# Why this test exists: Gemini Code Assist has flagged this case statement
# three times (PR #15 → PR #19 → PR #20 → PR #21). The patterns are subtle
# (bash globs, not regex) and an off-by-one in a character class silently
# flips classifications for multi-digit components. This test pins the
# contract so it can't drift again. Cases that once silently fell through
# to "unknown" — notably 20.x and 200.x — are now pinned here explicitly.
#
# Run from the repo root or via smoke-test.sh.

set -e

. "$(dirname "$0")/test_helper.sh"

# Mirror of the case statement in setup and bin/idstack-doctor. Keep these
# patterns in lockstep with both files — if you change one, change all three.
classify_version() {
  case "$1" in
    2.0.[1-9]*|2.[1-9]*|[3-9]*|[1-9][0-9]*) echo "skip" ;;
    0.*|1.*|2.0.0.*|2.0.0) echo "legacy" ;;
    *) echo "unknown" ;;
  esac
}

check_version() {
  TOTAL=$((TOTAL + 1))
  local version="$1"
  local expected="$2"
  local got
  got="$(classify_version "$version")"
  if [ "$got" = "$expected" ]; then
    PASS=$((PASS + 1))
    echo "  PASS: $version -> $got"
  else
    FAIL=$((FAIL + 1))
    echo "  FAIL: $version -> $got (expected $expected)"
  fi
}

echo "test-version-classifier"
echo ""

# Legacy versions that ever shipped.
check_version "0.1.0"   legacy
check_version "0.5.0"   legacy
check_version "1.0.0"   legacy
check_version "1.9.0"     legacy
check_version "2.0.0"     legacy
check_version "2.0.0.0"   legacy
check_version "2.0.0.1"   legacy

# Modern versions — including multi-digit components that broke the
# previous patterns.
check_version "2.0.1.0"   skip
check_version "2.0.1.5"   skip
check_version "2.0.10.0"  skip
check_version "2.0.99.0"  skip
check_version "2.1.0.0"   skip
check_version "2.4.0.0"   skip
check_version "2.10.0.0"  skip
check_version "2.99.0.0"  skip
check_version "3.0.0.0"   skip
check_version "9.0.0.0"   skip
check_version "10.0.0.0"  skip
check_version "19.0.0.0"  skip
check_version "100.0.0.0" skip

# Future major versions where the major itself is multi-digit but does not
# start with 1. Caught by Gemini on PR #21 — the previous 1[0-9]* arm
# missed these and silently fell through to "unknown". Now classified by
# [1-9][0-9]*.
check_version "20.0.0.0"  skip
check_version "21.5.0"    skip
check_version "25.99.0"   skip
check_version "29.0.0"    skip
check_version "30.0.0"    skip
check_version "200.0.0"   skip
check_version "999.0.0"   skip

echo ""
echo "  $PASS/$TOTAL passed"
[ "$FAIL" = "0" ] || exit 1