Skip to content

Commit 976a7c3

Browse files
Copilotsayedimac
andcommitted
Address code review feedback: improve variable descriptions and fix ACR module
Co-authored-by: sayedimac <25403967+sayedimac@users.noreply.github.com>
1 parent 9f3eef1 commit 976a7c3

4 files changed

Lines changed: 5 additions & 6 deletions

File tree

azd/aca/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ variable "container_port" {
3232

3333
variable "cpu_cores" {
3434
type = string
35-
description = "CPU cores allocated to the container"
35+
description = "CPU cores allocated to the container (e.g., '0.5', '1.0')"
3636
default = "0.5"
3737
}
3838

3939
variable "memory_in_gb" {
4040
type = string
41-
description = "Memory allocated to the container in GB"
41+
description = "Memory allocated to the container (e.g., '1Gi', '2Gi')"
4242
default = "1Gi"
4343
}

azd/aci/variables.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ variable "container_port" {
3232

3333
variable "cpu_cores" {
3434
type = string
35-
description = "CPU cores allocated to the container instance"
35+
description = "CPU cores allocated to the container instance (e.g., '0.5', '1.0', '2.0')"
3636
default = "1.0"
3737
}
3838

3939
variable "memory_in_gb" {
4040
type = string
41-
description = "Memory allocated to the container instance in GB"
41+
description = "Memory allocated to the container instance in GB (e.g., '1.0', '1.5', '2.0')"
4242
default = "1.5"
4343
}

azd/acr/modules/acr.tf

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,11 @@ variable "registry_name" {
3030
variable "location" {
3131
type = string
3232
description = "Azure region location"
33-
default = null
3433
}
3534

3635
variable "resource_group_name" {
3736
type = string
3837
description = "Name of the resource group"
39-
default = null
4038
}
4139

4240
variable "sku" {

azd/aks/main.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ resource "azurerm_container_registry" "acr" {
4343
}
4444

4545
# AKS Cluster
46+
# Note: RBAC is disabled to match the Bicep configuration, but enabling RBAC is recommended for production
4647
resource "azurerm_kubernetes_cluster" "aks" {
4748
name = "aks-${random_string.resource_token.result}"
4849
location = azurerm_resource_group.main.location

0 commit comments

Comments
 (0)