Skip to content

chore: new-arch-only, packaging, docs and hygiene (audit PR 6/6)#125

Merged
sbaiahmed1 merged 1 commit into
mainfrom
fix/pr6-packaging-docs-hygiene
Jul 16, 2026
Merged

chore: new-arch-only, packaging, docs and hygiene (audit PR 6/6)#125
sbaiahmed1 merged 1 commit into
mainfrom
fix/pr6-packaging-docs-hygiene

Conversation

@sbaiahmed1

@sbaiahmed1 sbaiahmed1 commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Part 6 of 6 in the July 2026 audit remediation. Stacked on fix/pr5-ts-api-tests.

New-architecture-only, packaging, docs and hygiene.

  • IOS-11 (old arch dismissed): removed the five legacy Paper RCTViewManager pairs — the library is Fabric-only. README states New Architecture required (RN 0.76+); peerDependencies move from * to react >=18.2.0 / react-native >=0.76.0.
  • TS-04 podspec source URL fixed; files whitelist pruned of non-existent cpp/react-native.config.js.
  • IOS-09 VibrancyView uses the shared style helper (fixes extraDark); deleted dead glassEffectFromString + template header guard.
  • IOS-10 documented the private-CAFilter risk; AND-09 renamed the package file to match its class; TS-06/TS-NEW-2 README marks blurRounds Android-only.

Deferred: REPO-01/02 (large demo media in the git pack) need external hosting / history rewrite — kept as recommendations in the audit report.

Verified: iOS rebuilds and runs after removing the Paper managers (BlurView, Liquid Glass + container, tints all render, no redbox); tsc + eslint clean; 11 tests pass.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@sbaiahmed1, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 68b3b076-616b-4a47-bbce-97cc5eb753c3

📥 Commits

Reviewing files that changed from the base of the PR and between ca0deaa and f72b766.

📒 Files selected for processing (18)
  • README.md
  • ReactNativeBlur.podspec
  • android/src/main/java/com/sbaiahmed1/reactnativeblur/ReactNativeBlurViewPackage.kt
  • ios/Helpers/BlurStyleHelpers.swift
  • ios/ReactNativeBlurViewManager.h
  • ios/ReactNativeBlurViewManager.mm
  • ios/ReactNativeLiquidGlassContainerManager.h
  • ios/ReactNativeLiquidGlassContainerManager.mm
  • ios/ReactNativeLiquidGlassViewManager.h
  • ios/ReactNativeLiquidGlassViewManager.mm
  • ios/ReactNativeProgressiveBlurView.h
  • ios/ReactNativeProgressiveBlurViewManager.h
  • ios/ReactNativeProgressiveBlurViewManager.mm
  • ios/ReactNativeVibrancyViewManager.h
  • ios/ReactNativeVibrancyViewManager.mm
  • ios/Views/VariableBlurView.swift
  • ios/Views/VibrancyEffectView.swift
  • package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/pr6-packaging-docs-hygiene

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sbaiahmed1
sbaiahmed1 force-pushed the fix/pr5-ts-api-tests branch from 5324b35 to 91b8bab Compare July 16, 2026 19:10
Base automatically changed from fix/pr5-ts-api-tests to main July 16, 2026 19:10
Addresses the PR 6 batch from the July 2026 audit.

- IOS-11 (old architecture dismissed): removed the five legacy Paper
  RCTViewManager pairs (ReactNativeBlurViewManager and siblings). The library
  ships Fabric components only — registration goes through the codegen
  componentProvider and the component Cls() functions, so the Paper managers
  were dead weight (and the two glass ones were broken). README now states the
  New Architecture is required (RN 0.76+), and peerDependencies move from "*"
  to react >=18.2.0 / react-native >=0.76.0 (TS-04).
- TS-04: fixed the podspec source URL (…/react-native-blur.git, was
  …/sbaiahmed1-react-native-blur.git) and pruned the `files` whitelist of the
  non-existent `cpp` and `react-native.config.js` entries.
- IOS-09: VibrancyEffectView now uses the shared blurStyleFromString helper
  instead of a private duplicate, so blurType="extraDark" maps correctly
  instead of silently falling back; deleted the unused glassEffectFromString
  helper and the leftover NativeComponentExampleComponentView header guard.
  (Two more colorFromString copies went away with the Paper managers; the
  remaining three could still be shared in a follow-up.)
- IOS-10: documented the private CAFilter dependency and its App Store / OS
  fragility on VariableBlurView.
- AND-09: renamed ReactNativeBlurPackage.kt to match its class
  ReactNativeBlurViewPackage.
- TS-06 / TS-NEW-2: README marks blurRounds as Android-only.

Deferred: REPO-01/REPO-02 (large demo media in the git pack) need external
hosting or a coordinated history rewrite, so they remain recommendations in the
audit report rather than an in-tree change.

Verified: iOS rebuilds and runs after removing the Paper managers — BlurView,
the Liquid Glass screen (glass + container with children) and the tint swatches
all render with no redbox; tsc and eslint clean; 11 jest tests pass.
@sbaiahmed1
sbaiahmed1 force-pushed the fix/pr6-packaging-docs-hygiene branch from 19e04fc to f72b766 Compare July 16, 2026 19:11
@sbaiahmed1
sbaiahmed1 merged commit 62ca113 into main Jul 16, 2026
0 of 5 checks passed
@sbaiahmed1
sbaiahmed1 deleted the fix/pr6-packaging-docs-hygiene branch July 16, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant