Skip to content

Commit 165ae0d

Browse files
committed
Remove redundant min version checks
We dropped support for firefox older than 58 a long time back. We dropped support node older than 18.1 in emscripten-core#26604.
1 parent 54ef4c6 commit 165ae0d

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

tools/minimal_runtime_shell.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ def generate_minimal_runtime_load_statement(target_basename):
2626
# Expand {{{ DOWNLOAD_WASM }}} block from here (if we added #define support, this could be done in
2727
# the template directly)
2828
if settings.MINIMAL_RUNTIME_STREAMING_WASM_COMPILATION:
29-
if settings.MIN_SAFARI_VERSION < 150000 or settings.MIN_NODE_VERSION < 180100 or settings.MIN_FIREFOX_VERSION < 58:
29+
if settings.MIN_SAFARI_VERSION < 150000:
3030
# https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/compileStreaming
3131
download_wasm = f"WebAssembly.compileStreaming ? WebAssembly.compileStreaming(fetch('{target_basename}.wasm')) : binary('{target_basename}.wasm')"
3232
else:
@@ -35,7 +35,7 @@ def generate_minimal_runtime_load_statement(target_basename):
3535
elif settings.MINIMAL_RUNTIME_STREAMING_WASM_INSTANTIATION:
3636
# Same compatibility story as above for
3737
# https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/WebAssembly/instantiateStreaming
38-
if settings.MIN_SAFARI_VERSION < 150000 or settings.MIN_NODE_VERSION < 180100 or settings.MIN_FIREFOX_VERSION < 58:
38+
if settings.MIN_SAFARI_VERSION < 150000:
3939
download_wasm = f"!WebAssembly.instantiateStreaming && binary('{target_basename}.wasm')"
4040
else:
4141
# WebAssembly.instantiateStreaming() is unconditionally supported, so we do not download wasm

0 commit comments

Comments
 (0)