Skip to content

Commit 640e5ea

Browse files
committed
Simplify MIN_NODE_VERSION override from embind ts-gen.
Followup to emscripten-core#26604. I guess we still need to set `MIN_NODE_VERSION` in case the user specified MIN_NODE_VERSION=-1 (UNSUPPORTED).
1 parent 426fb2d commit 640e5ea

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/link.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1959,6 +1959,7 @@ def run_embind_gen(options, wasm_target, js_syms, extra_settings):
19591959
# Force node since that is where the tool runs.
19601960
if 'node' not in settings.ENVIRONMENT:
19611961
settings.ENVIRONMENT.append('node')
1962+
settings.MIN_NODE_VERSION = feature_matrix.OLDEST_SUPPORTED_NODE
19621963
settings.MINIMAL_RUNTIME = 0
19631964
# Required function to trigger TS generation.
19641965
settings.DEFAULT_LIBRARY_FUNCS_TO_INCLUDE += ['$callRuntimeCallbacks', '$addRunDependency', '$removeRunDependency']
@@ -1979,7 +1980,6 @@ def run_embind_gen(options, wasm_target, js_syms, extra_settings):
19791980
dirname, basename = os.path.split(lib)
19801981
if basename == 'libembind.js':
19811982
settings.JS_LIBRARIES[i] = os.path.join(dirname, 'libembind_gen.js')
1982-
settings.MIN_NODE_VERSION = 160000 if settings.MEMORY64 else 150000
19831983
# The final version of the memory64 proposal is not implemented until node
19841984
# v24, so we need to lower it away in order to execute the binary at build
19851985
# time.

0 commit comments

Comments
 (0)