Skip to content

Commit b44e10f

Browse files
authored
ide: goto def with view & qualified column (#1081)
1 parent 0b0fa65 commit b44e10f

2 files changed

Lines changed: 15 additions & 0 deletions

File tree

crates/squawk_ide/src/goto_definition.rs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2686,6 +2686,20 @@ select v.a$0 from v;
26862686
");
26872687
}
26882688

2689+
#[test]
2690+
fn goto_view_table_qualifier() {
2691+
assert_snapshot!(goto("
2692+
create view v as select 1 id, 2 b;
2693+
select v$0.id from v;
2694+
"), @"
2695+
╭▸
2696+
2 │ create view v as select 1 id, 2 b;
2697+
│ ─ 2. destination
2698+
3 │ select v.id from v;
2699+
╰╴ ─ 1. source
2700+
");
2701+
}
2702+
26892703
#[test]
26902704
fn goto_create_table_as_column() {
26912705
assert_snapshot!(goto("

crates/squawk_ide/src/resolve.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1147,6 +1147,7 @@ fn resolve_select_qualified_column_table_name_ptr(
11471147

11481148
let position = table_name_ref.syntax().text_range().start();
11491149
resolve_table_name_ptr(db, file, &table_name, &schema, position)
1150+
.or_else(|| resolve_view_name_ptr(db, file, &table_name, &schema, position))
11501151
}
11511152

11521153
enum ReturningClauseMatch {

0 commit comments

Comments
 (0)