fix: nflows inverse transform and retarget lc2st#1865
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1865 +/- ##
==========================================
+ Coverage 87.76% 87.90% +0.13%
==========================================
Files 143 143
Lines 13317 13402 +85
==========================================
+ Hits 11688 11781 +93
+ Misses 1629 1621 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dgedon
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when working on the LC2ST tests I noticed a typo in the
inverse_transformconvenience function forLC2STand then noticed that it is actually never used.This PR fixes the typo and then replaces the
lambdafunctions tonpe._net.transformwith the existing helper in the tutorials and the tests.