Skip to content

fix: nflows inverse transform and retarget lc2st#1865

Merged
janfb merged 3 commits into
mainfrom
fix-nflows-inverse-transform-and-retarget-lc2st
May 21, 2026
Merged

fix: nflows inverse transform and retarget lc2st#1865
janfb merged 3 commits into
mainfrom
fix-nflows-inverse-transform-and-retarget-lc2st

Conversation

@janfb
Copy link
Copy Markdown
Contributor

@janfb janfb commented May 19, 2026

when working on the LC2ST tests I noticed a typo in the inverse_transform convenience function for LC2ST and then noticed that it is actually never used.

This PR fixes the typo and then replaces the lambda functions to npe._net.transform with the existing helper in the tutorials and the tests.

@janfb janfb requested a review from manuelgloeckler May 19, 2026 16:11
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.90%. Comparing base (839762d) to head (adca39a).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1865      +/-   ##
==========================================
+ Coverage   87.76%   87.90%   +0.13%     
==========================================
  Files         143      143              
  Lines       13317    13402      +85     
==========================================
+ Hits        11688    11781      +93     
+ Misses       1629     1621       -8     
Flag Coverage Δ
fast 81.39% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sbi/neural_nets/estimators/nflows_flow.py 87.50% <100.00%> (+25.00%) ⬆️

... and 1 file with indirect coverage changes

@janfb janfb removed the request for review from manuelgloeckler May 21, 2026 08:39
@janfb janfb merged commit 38f43ca into main May 21, 2026
12 checks passed
@janfb janfb deleted the fix-nflows-inverse-transform-and-retarget-lc2st branch May 21, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants