Add RenderingEventCommand::bufferUnderrun

[sbooth]

No description provided.

[github-actions]

Cpp-linter Review

Used clang-format v22.1.8

Click here for the full clang-format patch

diff --git a/Sources/CSFBAudioEngine/Player/AudioPlayer.mm b/Sources/CSFBAudioEngine/Player/AudioPlayer.mm
index f6073cf..653424a 100644
--- a/Sources/CSFBAudioEngine/Player/AudioPlayer.mm
+++ b/Sources/CSFBAudioEngine/Player/AudioPlayer.mm
@@ -1695 +1695,2 @@ OSStatus sfb::AudioPlayer::render(BOOL &isSilence, const AudioTimeStamp &timesta
-                                       timestamp.mHostTime, static_cast<uint32_t>(framesRead), static_cast<uint32_t>(frameCount))) {
+                                       timestamp.mHostTime, static_cast<uint32_t>(framesRead),
+                                       static_cast<uint32_t>(frameCount))) {
@@ -2147 +2148,2 @@ bool sfb::AudioPlayer::processBufferUnderrunEvent() noexcept {
-    os_log_error(log_, "Audio ring buffer underrun: %u/%u frames rendered for host time %lu", framesRendered, framesRequested, hostTime);
+    os_log_error(log_, "Audio ring buffer underrun: %u/%u frames rendered for host time %lu", framesRendered,
+                 framesRequested, hostTime);

Have any feedback or feature suggestions? Share it here.

outdated suggestion

[Copilot]

Pull request overview

Adds a new rendering-event command to explicitly report audio ring-buffer underruns from the realtime render callback to the event-processing thread, enabling centralized handling/logging of underrun conditions.

Changes:

• Emit RenderingEventCommand::bufferUnderrun when the ring buffer returns fewer frames than requested.
• Extend rendering-event dispatch to handle bufferUnderrun and add processBufferUnderrunEvent().
• Update the RenderingEventCommand enum and event-processing API surface in the header.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
Sources/CSFBAudioEngine/Player/AudioPlayer.mm	Writes a new underrun event from render() and adds a handler to process/log it on the event thread.
Sources/CSFBAudioEngine/Player/AudioPlayer.h	Adds the new RenderingEventCommand::bufferUnderrun and declares processBufferUnderrunEvent().

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.