Improve Admin Management UX: permissions, search, table, tooltips, and mobile fixes - #1532
Open
maxijabase wants to merge 10 commits into
Open
Improve Admin Management UX: permissions, search, table, tooltips, and mobile fixes#1532maxijabase wants to merge 10 commits into
maxijabase wants to merge 10 commits into
Conversation
Text filters on Advanced search always substring-match, so the Exact/Partial toggles are gone. Web and server permission fields use a themed multi-select over the real <select multiple>, so GET submit and no-JS still work. Also fix server-permission filtering: pass aid not authid, keep SM flags as chars, and allow SM_CUSTOM1-6 in the allowlist so custom flags round-trip after search.
Add per-card select-all and clearer permission group separators. Drop the empty AdminTabs back strip that left dead space under the topbar, and put Back on the shared Details/Group/Servers/Permissions tab row instead.
The fixed 3-column grid overflowed the card on narrow viewports. Stack Type/Name/Flags below 768px and keep the desktop row.
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
I will add screenshots of my changes soon. |
Contributor
Author
AdminsBefore:chrome_vz1jOWxgf0.mp4After:chrome_foXckWc3P4.mp4 |
Contributor
Author
Edit AdminsBeforechrome_FLYuZrHBHp.mp4Afterchrome_tECm4YS2cE.mp4 |
Contributor
|
Nice. Can you adjust your code to satisfy the php ci ? |
Contributor
Author
ofc, working on that rn |
Contributor
Author
|
I wouldn't tag a new release just yet, I'd like to check the rest of the site and potentially send new PRs before that. |
The global <=768px .table hide is for list pages with card mirrors. Form tables (overrides, edit-group perms) have no mirror and must opt out via table--keep-mobile so empty/edit rows do not vanish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is a focused pass over Admin Management. It fixes the broken Edit Admins permission path, brings the admins list and search up to the current panel chrome, improves the edit-admin permissions editor, and closes a few mobile layout bugs along the way.
Permission fix
Admins list and table
.table-under-768px rule (those forms need the table layout).Advanced search
<select multiple>, so GET submit and no-JS still work.aid(notauthid), keep SM flags as characters, and allowSM_CUSTOM1throughSM_CUSTOM6in the allowlist.Edit admin (Details / Group / Servers / Permissions)
Tooltips
sb.js/ theme CSS so hover help works again where templates expect it.Overrides mobile
Test plan