Skip to content

Improve Admin Management UX: permissions, search, table, tooltips, and mobile fixes - #1532

Open
maxijabase wants to merge 10 commits into
sbpp:mainfrom
maxijabase:improve/admin-panel-ux
Open

Improve Admin Management UX: permissions, search, table, tooltips, and mobile fixes#1532
maxijabase wants to merge 10 commits into
sbpp:mainfrom
maxijabase:improve/admin-panel-ux

Conversation

@maxijabase

@maxijabase maxijabase commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR is a focused pass over Admin Management. It fixes the broken Edit Admins permission path, brings the admins list and search up to the current panel chrome, improves the edit-admin permissions editor, and closes a few mobile layout bugs along the way.

Permission fix

Admins list and table

  • Refreshed the admins list row actions and desktop table styling so it matches the rest of the panel.
  • Kept permission tables usable on mobile by opting them out of the global hide-.table-under-768px rule (those forms need the table layout).

Advanced search

  • Dropped Exact / Partial toggles. Name, Steam ID, and email always substring-match.
  • Web and server permission filters use a themed multi-select over a real <select multiple>, so GET submit and no-JS still work.
  • Fixed server-permission filtering: use aid (not authid), keep SM flags as characters, and allow SM_CUSTOM1 through SM_CUSTOM6 in the allowlist.

Edit admin (Details / Group / Servers / Permissions)

  • Shared tab strip across all four edit-admin pages, including Permissions.
  • Removed the empty AdminTabs Back strip that left dead space under the topbar.
  • Put Back on the right of the in-page tab row (links to the admins list).
  • Permissions editor: Select all per card, clearer category grouping (parent vs child rows), and section labels on the server flags table.
  • Side-by-side Web / Server permission cards on wide screens, stacked on smaller ones.

Tooltips

  • Restored the tooltip UI helper in sb.js / theme CSS so hover help works again where templates expect it.

Overrides mobile

Test plan

  • Log in as an admin with Edit Admins but not Owner. Open another admin and confirm Details / password save works.
  • Admins list: row actions, desktop table, and mobile cards look correct.
  • Advanced search: name / Steam / email substring search works without Exact/Partial.
  • Advanced search: multi-select web + server permissions filter correctly, including custom SM flags.
  • Edit admin tabs: Details / Group / Servers / Permissions share the same strip; Back returns to the admins list with no blank gap under the topbar.
  • Permissions: Select all / category parent toggles / individual children behave as expected; save still works.
  • Permissions on a phone-width viewport: tables stay visible.
  • Overrides on mobile: Add an override fields stack and stay inside the card.
  • Hover tooltips where the panel still uses them.

Text filters on Advanced search always substring-match, so the Exact/Partial toggles are gone.

Web and server permission fields use a themed multi-select over the real <select multiple>, so GET submit and no-JS still work.

Also fix server-permission filtering: pass aid not authid, keep SM flags as chars, and allow SM_CUSTOM1-6 in the allowlist so custom flags round-trip after search.
Add per-card select-all and clearer permission group separators.
Drop the empty AdminTabs back strip that left dead space under the
topbar, and put Back on the shared Details/Group/Servers/Permissions
tab row instead.
The fixed 3-column grid overflowed the card on narrow viewports.
Stack Type/Name/Flags below 768px and keep the desktop row.
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@maxijabase

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@maxijabase

Copy link
Copy Markdown
Contributor Author

I will add screenshots of my changes soon.

github-actions Bot added a commit that referenced this pull request Jul 29, 2026
@maxijabase

Copy link
Copy Markdown
Contributor Author

Admins

Before:

chrome_vz1jOWxgf0.mp4

After:

chrome_foXckWc3P4.mp4

@maxijabase

Copy link
Copy Markdown
Contributor Author

Edit Admins

Before

chrome_FLYuZrHBHp.mp4

After

chrome_tECm4YS2cE.mp4

@Rushaway

Copy link
Copy Markdown
Contributor

Nice. Can you adjust your code to satisfy the php ci ?

@maxijabase

Copy link
Copy Markdown
Contributor Author

Nice. Can you adjust your code to satisfy the php ci ?

ofc, working on that rn

@maxijabase

Copy link
Copy Markdown
Contributor Author

I wouldn't tag a new release just yet, I'd like to check the rest of the site and potentially send new PRs before that.

@Rushaway
Rushaway requested a review from rumblefrog July 29, 2026 14:16
The global <=768px .table hide is for list pages with card mirrors.
Form tables (overrides, edit-group perms) have no mirror and must opt
out via table--keep-mobile so empty/edit rows do not vanish.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit Admins not working as expected Group Override Text Wrapping

2 participants