Skip to content

Commit baa49bf

Browse files
sbryngelsonclaude
andcommitted
Fix bench: use PR's submit.sh for master job to get SIGKILL recovery
When benchmarking master vs PR, submit_and_monitor_bench.sh was using the master directory's submit.sh for the master bench job. Master's submit.sh calls monitor_slurm_job.sh directly without SIGKILL recovery. When the monitor was killed (exit 137), the master bench YAML was never found. Fix: always use the PR's submit.sh (which calls run_monitored_slurm_job.sh with sacct fallback) for both master and PR bench submissions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 2caf95f commit baa49bf

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

.github/scripts/submit_and_monitor_bench.sh

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,13 @@ cluster="$4"
1717
echo "[$dir] Submitting benchmark for $device-$interface on $cluster..."
1818
cd "$dir"
1919

20-
# Submit and monitor job (submit.sh auto-detects bench mode from script name)
21-
bash .github/workflows/$cluster/submit.sh \
22-
.github/workflows/$cluster/bench.sh "$device" "$interface"
20+
# Always use the PR's submit.sh so both master and PR builds benefit from the
21+
# run_monitored_slurm_job.sh SIGKILL recovery wrapper. The bench script is
22+
# still resolved relative to the current directory (master/ or pr/) so the
23+
# correct branch code is benchmarked. SLURM_SUBMIT_DIR ensures the job runs
24+
# in the right directory regardless of which submit.sh is invoked.
25+
PR_SUBMIT="${SCRIPT_DIR}/../workflows/${cluster}/submit.sh"
26+
bash "$PR_SUBMIT" .github/workflows/$cluster/bench.sh "$device" "$interface"
2327

2428
# Verify the YAML output file was created
2529
job_slug="bench-$device-$interface"

0 commit comments

Comments
 (0)