Skip to content

Commit 5e6d11a

Browse files
authored
Merge pull request #215 from xuwei-k/sbt-2-0-0-RC9
sbt 2.0.0-RC9
2 parents 6b89abd + 569d682 commit 5e6d11a

2 files changed

Lines changed: 53 additions & 24 deletions

File tree

.github/workflows/ci.yml

Lines changed: 24 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
matrix:
2525
os: [ubuntu-latest, macos-latest, windows-latest]
2626
scala: [2.12.20]
27-
java: [zulu@8, graal_graalvm@17, corretto@17]
27+
java: [corretto@17, graal_graalvm@17, zulu@8]
2828
runs-on: ${{ matrix.os }}
2929
steps:
3030
- name: Ignore line ending differences in git
@@ -45,12 +45,12 @@ jobs:
4545
with:
4646
fetch-depth: 0
4747

48-
- name: Setup Java (zulu@8)
49-
if: matrix.java == 'zulu@8'
48+
- name: Setup Java (corretto@17)
49+
if: matrix.java == 'corretto@17'
5050
uses: actions/setup-java@v5
5151
with:
52-
distribution: zulu
53-
java-version: 8
52+
distribution: corretto
53+
java-version: 17
5454
cache: sbt
5555

5656
- name: Setup GraalVM (graal_graalvm@17)
@@ -63,12 +63,12 @@ jobs:
6363
github-token: ${{ secrets.GITHUB_TOKEN }}
6464
cache: sbt
6565

66-
- name: Setup Java (corretto@17)
67-
if: matrix.java == 'corretto@17'
66+
- name: Setup Java (zulu@8)
67+
if: matrix.java == 'zulu@8'
6868
uses: actions/setup-java@v5
6969
with:
70-
distribution: corretto
71-
java-version: 17
70+
distribution: zulu
71+
java-version: 8
7272
cache: sbt
7373

7474
- name: Setup sbt
@@ -78,9 +78,14 @@ jobs:
7878
shell: bash
7979
run: sbt '++ ${{ matrix.scala }}' githubWorkflowCheck
8080

81-
- shell: bash
81+
- if: matrix.java != 'zulu@8'
82+
shell: bash
8283
run: sbt '++ ${{ matrix.scala }}' '+ test' '+ scripted'
8384

85+
- if: matrix.java == 'zulu@8'
86+
shell: bash
87+
run: sbt '++ ${{ matrix.scala }}' test scripted
88+
8489
- name: Clean up Ivy Local repo
8590
shell: bash
8691
run: rm -rf "$HOME/.ivy2/local"
@@ -103,7 +108,7 @@ jobs:
103108
matrix:
104109
os: [ubuntu-latest]
105110
scala: [2.12.20]
106-
java: [zulu@8]
111+
java: [corretto@17]
107112
runs-on: ${{ matrix.os }}
108113
steps:
109114
- name: Ignore line ending differences in git
@@ -123,12 +128,12 @@ jobs:
123128
with:
124129
fetch-depth: 0
125130

126-
- name: Setup Java (zulu@8)
127-
if: matrix.java == 'zulu@8'
131+
- name: Setup Java (corretto@17)
132+
if: matrix.java == 'corretto@17'
128133
uses: actions/setup-java@v5
129134
with:
130-
distribution: zulu
131-
java-version: 8
135+
distribution: corretto
136+
java-version: 17
132137
cache: sbt
133138

134139
- name: Setup GraalVM (graal_graalvm@17)
@@ -141,12 +146,12 @@ jobs:
141146
github-token: ${{ secrets.GITHUB_TOKEN }}
142147
cache: sbt
143148

144-
- name: Setup Java (corretto@17)
145-
if: matrix.java == 'corretto@17'
149+
- name: Setup Java (zulu@8)
150+
if: matrix.java == 'zulu@8'
146151
uses: actions/setup-java@v5
147152
with:
148-
distribution: corretto
149-
java-version: 17
153+
distribution: zulu
154+
java-version: 8
150155
cache: sbt
151156

152157
- name: Setup sbt

build.sbt

Lines changed: 29 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,29 @@ ThisBuild / crossScalaVersions := Seq(scala212)
2222
ThisBuild / scalaVersion := scala212
2323

2424
ThisBuild / githubWorkflowOSes := Seq("ubuntu-latest", "macos-latest", "windows-latest")
25-
ThisBuild / githubWorkflowBuild := Seq(WorkflowStep.Sbt(List("+ test", "+ scripted")))
25+
ThisBuild / githubWorkflowBuild := Seq(
26+
WorkflowStep.Sbt(
27+
commands = List("+ test", "+ scripted"),
28+
cond = Some("matrix.java != 'zulu@8'")
29+
),
30+
WorkflowStep.Sbt(
31+
commands = List("test", "scripted"),
32+
cond = Some("matrix.java == 'zulu@8'")
33+
),
34+
)
2635
ThisBuild / githubWorkflowBuildPostamble += WorkflowStep.Run(
2736
commands = List("""rm -rf "$HOME/.ivy2/local""""),
2837
name = Some("Clean up Ivy Local repo")
2938
)
30-
ThisBuild / githubWorkflowJavaVersions ++= Seq(
39+
40+
def publishTaskJavaSpec = JavaSpec.corretto("17")
41+
42+
ThisBuild / githubWorkflowJavaVersions := Seq(
43+
// https://github.com/sbt/sbt-github-actions/issues/216
44+
// https://github.com/sbt/sbt-github-actions/blob/6b89abdd5381ef61870b/src/main/scala/sbtghactions/GenerativePlugin.scala#L738
45+
publishTaskJavaSpec,
3146
JavaSpec.graalvm(Graalvm.Distribution("graalvm"), "17"),
32-
JavaSpec.corretto("17")
47+
JavaSpec.zulu("8"),
3348
)
3449

3550
ThisBuild / githubWorkflowTargetTags ++= Seq("v*")
@@ -56,16 +71,25 @@ pluginCrossBuild / sbtVersion := {
5671
case "2.12" =>
5772
"1.5.5"
5873
case _ =>
59-
"2.0.0-RC6"
74+
"2.0.0-RC9"
6075
}
6176
}
62-
crossScalaVersions += "3.7.3"
77+
crossScalaVersions += "3.8.1"
6378

6479
publishMavenStyle := true
6580

6681
scalacOptions +=
6782
"-Xlint:_,-missing-interpolator"
6883

84+
scalacOptions ++= {
85+
scalaBinaryVersion.value match {
86+
case "2.12" =>
87+
Seq("-release:8")
88+
case "3" =>
89+
Nil
90+
}
91+
}
92+
6993
libraryDependencies += "org.specs2" %% "specs2-core" % "4.20.8" % Test
7094

7195
enablePlugins(SbtPlugin)

0 commit comments

Comments
 (0)